Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2238903003: ash: Remove WmShelf::IsShowingOverflowBubble (Closed)

Created:
4 years, 4 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Remove WmShelf::IsShowingOverflowBubble It's no longer needed now that ShelfView has moved into //ash/common. Just cleanup, no functional changes. BUG=615155 TEST=ash_unittests Committed: https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3 Cr-Commit-Position: refs/heads/master@{#411431}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -107 lines) Patch
M ash/aura/wm_shelf_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/aura/wm_shelf_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/shelf/overflow_button.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/common/shelf/overflow_button.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M ash/common/shelf/shelf_view.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/common/shelf/shelf_view.cc View 2 chunks +76 lines, -76 lines 2 comments Download
M ash/common/shelf/wm_shelf.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/mus/bridge/wm_shelf_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/bridge/wm_shelf_mus.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/shelf/shelf.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
James Cook
msw, please take a look. I didn't do WmShelf::SchedulePaint because that might involve adding some ...
4 years, 4 months ago (2016-08-11 22:02:12 UTC) #3
msw
lgtm https://codereview.chromium.org/2238903003/diff/1/ash/common/shelf/shelf_view.cc File ash/common/shelf/shelf_view.cc (right): https://codereview.chromium.org/2238903003/diff/1/ash/common/shelf/shelf_view.cc#newcode556 ash/common/shelf/shelf_view.cc:556: void ShelfView::ButtonPressed(views::Button* sender, On 2016/08/11 22:02:12, James Cook ...
4 years, 4 months ago (2016-08-11 22:06:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238903003/1
4 years, 4 months ago (2016-08-11 22:31:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 22:45:02 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 22:47:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65ae2bba5625bc75256123ee8ee955ecc38db9e3
Cr-Commit-Position: refs/heads/master@{#411431}

Powered by Google App Engine
This is Rietveld 408576698