Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: ash/common/shelf/wm_shelf.h

Issue 2238903003: ash: Remove WmShelf::IsShowingOverflowBubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_SHELF_WM_SHELF_H_ 5 #ifndef ASH_COMMON_SHELF_WM_SHELF_H_
6 #define ASH_COMMON_SHELF_WM_SHELF_H_ 6 #define ASH_COMMON_SHELF_WM_SHELF_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "ash/common/shelf/shelf_types.h" 9 #include "ash/common/shelf/shelf_types.h"
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 // widget. Returns null if shelf dimming is not supported (e.g. on mus). 57 // widget. Returns null if shelf dimming is not supported (e.g. on mus).
58 // TODO(jamescook): Delete this after material design ships, as MD will not 58 // TODO(jamescook): Delete this after material design ships, as MD will not
59 // require shelf dimming. http://crbug.com/614453 59 // require shelf dimming. http://crbug.com/614453
60 virtual WmDimmerView* CreateDimmerView(bool disable_animations_for_test) = 0; 60 virtual WmDimmerView* CreateDimmerView(bool disable_animations_for_test) = 0;
61 61
62 // Shelf items are slightly dimmed (e.g. when a window is maximized). 62 // Shelf items are slightly dimmed (e.g. when a window is maximized).
63 // TODO(jamescook): Delete this after material design ships, as MD will not 63 // TODO(jamescook): Delete this after material design ships, as MD will not
64 // require shelf dimming. http://crbug.com/614453 64 // require shelf dimming. http://crbug.com/614453
65 virtual bool IsDimmed() const = 0; 65 virtual bool IsDimmed() const = 0;
66 66
67 // Whether the shelf item overflow bubble is visible.
68 // TODO(jamescook): Eliminate when ShelfView moves to //ash/common.
69 // http://crbug.com/615155
70 virtual bool IsShowingOverflowBubble() const = 0;
71
72 // Schedules a repaint for all shelf buttons. 67 // Schedules a repaint for all shelf buttons.
73 // TODO(jamescook): Eliminate when ShelfView moves to //ash/common. 68 // TODO(jamescook): Eliminate when ShelfView moves to //ash/common.
74 // http://crbug.com/615155 69 // http://crbug.com/615155
75 virtual void SchedulePaint() = 0; 70 virtual void SchedulePaint() = 0;
76 71
77 // Whether the shelf view is visible. 72 // Whether the shelf view is visible.
78 // TODO(jamescook): Consolidate this with GetVisibilityState(). 73 // TODO(jamescook): Consolidate this with GetVisibilityState().
79 virtual bool IsVisible() const = 0; 74 virtual bool IsVisible() const = 0;
80 75
81 virtual void UpdateVisibilityState() = 0; 76 virtual void UpdateVisibilityState() = 0;
(...skipping 26 matching lines...) Expand all
108 virtual ShelfLockingManager* GetShelfLockingManagerForTesting() = 0; 103 virtual ShelfLockingManager* GetShelfLockingManagerForTesting() = 0;
109 virtual ShelfView* GetShelfViewForTesting() = 0; 104 virtual ShelfView* GetShelfViewForTesting() = 0;
110 105
111 protected: 106 protected:
112 virtual ~WmShelf() {} 107 virtual ~WmShelf() {}
113 }; 108 };
114 109
115 } // namespace ash 110 } // namespace ash
116 111
117 #endif // ASH_COMMON_SHELF_WM_SHELF_H_ 112 #endif // ASH_COMMON_SHELF_WM_SHELF_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698