Issue 2238883005: POC for InspectorInstrumentation adding InspectorWebPerfAgent

Created:
4 years, 4 months ago by panicker

Modified:
3 years, 10 months ago

Reviewers:
Sami

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

POC for InspectorInstrumentation adding InspectorWebPerfAgent BUG=

Patch Set 1 #

Patch Set 2 : Add task observer to WebPerfAgent #

Total comments: 5

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -6 lines)			Patch
M	components/scheduler/base/task_queue_manager.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/core.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/LocalFrame.h	View		3 chunks	+4 lines, -0 lines	1 comment	Download
M	third_party/WebKit/Source/core/frame/LocalFrame.cpp	View		5 chunks	+25 lines, -2 lines	3 comments	Download
M	third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
A	third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
A	third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/timing/Performance.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/timing/Performance.cpp	View		1 chunk	+5 lines, -0 lines	1 comment	Download
M	third_party/WebKit/Source/core/timing/PerformanceBase.h	View		4 chunks	+6 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/timing/PerformanceBase.cpp	View		4 chunks	+20 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/timing/WorkerPerformance.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sami

https://codereview.chromium.org/2238883005/diff/20001/third_party/WebKit/Source/core/frame/LocalFrame.cpp File third_party/WebKit/Source/core/frame/LocalFrame.cpp (right): https://codereview.chromium.org/2238883005/diff/20001/third_party/WebKit/Source/core/frame/LocalFrame.cpp#newcode859 third_party/WebKit/Source/core/frame/LocalFrame.cpp:859: void LocalFrame::enableWebPerfInspectorInstrumentation() Could we have a way to disable ...

4 years, 4 months ago (2016-08-17 10:40:28 UTC) #2

panicker

On 2016/08/17 10:40:28, Sami wrote: > https://codereview.chromium.org/2238883005/diff/20001/third_party/WebKit/Source/core/frame/LocalFrame.cpp > File third_party/WebKit/Source/core/frame/LocalFrame.cpp (right): > > https://codereview.chromium.org/2238883005/diff/20001/third_party/WebKit/Source/core/frame/LocalFrame.cpp#newcode859 > ...

4 years, 4 months ago (2016-08-17 19:09:23 UTC) #3

pfeldman

drive by since it triggered my folder watches. https://codereview.chromium.org/2238883005/diff/20001/third_party/WebKit/Source/core/frame/LocalFrame.cpp File third_party/WebKit/Source/core/frame/LocalFrame.cpp (right): https://codereview.chromium.org/2238883005/diff/20001/third_party/WebKit/Source/core/frame/LocalFrame.cpp#newcode828 third_party/WebKit/Source/core/frame/LocalFrame.cpp:828: if ...

4 years, 4 months ago (2016-08-17 21:12:11 UTC) #6

panicker

4 years, 4 months ago (2016-08-18 23:24:16 UTC) #7

Thanks for the comments, Pavel.
I'm preparing the actual CL and will address them there, this was just a
prototype demonstrating the plumbing.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages