POC for InspectorInstrumentation adding InspectorWebPerfAgent

third_party/WebKit/Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 29 matching lines @@
 #include "core/editing/InputMethodController.h"
 #include "core/editing/serializers/Serialization.h"
 #include "core/editing/spellcheck/SpellChecker.h"
 #include "core/events/Event.h"
 #include "core/fetch/ResourceFetcher.h"
 #include "core/frame/EventHandlerRegistry.h"
 #include "core/frame/FrameConsole.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalDOMWindow.h"
+#include "core/frame/Location.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLFrameElementBase.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/input/EventHandler.h"
+#include "core/inspector/InspectedFrames.h"
 #include "core/inspector/InspectorInstrumentation.h"
+#include "core/inspector/InspectorWebPerfAgent.h"
 #include "core/layout/HitTestResult.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/layout/compositing/PaintLayerCompositor.h"
 #include "core/loader/FrameLoadRequest.h"
 #include "core/loader/FrameLoaderClient.h"
 #include "core/loader/NavigationScheduler.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/FocusController.h"
 #include "core/page/Page.h"
 #include "core/page/scrolling/ScrollingCoordinator.h"
 #include "core/paint/ObjectPainter.h"
 #include "core/paint/PaintInfo.h"
 #include "core/paint/PaintLayer.h"
 #include "core/paint/TransformRecorder.h"
 #include "core/svg/SVGDocumentExtensions.h"
+#include "core/timing/DOMWindowPerformance.h"
 #include "platform/DragImage.h"
 #include "platform/JSONValues.h"
 #include "platform/PluginScriptForbiddenScope.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/ScriptForbiddenScope.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/StaticBitmapImage.h"
 #include "platform/graphics/paint/ClipRecorder.h"
 #include "platform/graphics/paint/PaintController.h"
 #include "platform/graphics/paint/SkPictureBuilder.h"
@@ skipping 229 matching lines @@
 LocalFrame::~LocalFrame()
 {
     // Verify that the FrameView has been cleared as part of detaching
     // the frame owner.
     ASSERT(!m_view);
 }
 
 DEFINE_TRACE(LocalFrame)
 {
     visitor->trace(m_instrumentingAgents);
+    visitor->trace(m_inspectorWebPerformanceAgent);
     visitor->trace(m_loader);
     visitor->trace(m_navigationScheduler);
     visitor->trace(m_view);
     visitor->trace(m_domWindow);
     visitor->trace(m_pagePopupOwner);
     visitor->trace(m_script);
     visitor->trace(m_editor);
     visitor->trace(m_spellChecker);
     visitor->trace(m_selection);
     visitor->trace(m_eventHandler);
@@ skipping 483 matching lines @@
     , m_selection(FrameSelection::create(this))
     , m_eventHandler(new EventHandler(this))
     , m_console(FrameConsole::create(*this))
     , m_inputMethodController(InputMethodController::create(*this))
     , m_navigationDisableCount(0)
     , m_pageZoomFactor(parentPageZoomFactor(this))
     , m_textZoomFactor(parentTextZoomFactor(this))
     , m_inViewSourceMode(false)
     , m_interfaceProvider(interfaceProvider)
 {
-    if (isLocalRoot())
+    if (isLocalRoot()) {

[pfeldman, 2016/08/17 21:12:10]

revert these

         m_instrumentingAgents = new InstrumentingAgents();
-    else
+    } else {
         m_instrumentingAgents = localFrameRoot()->m_instrumentingAgents;
+    }
 }
 
 WebFrameScheduler* LocalFrame::frameScheduler()
 {
     return m_frameScheduler.get();
 }
 
 void LocalFrame::scheduleVisualUpdateUnlessThrottled()
 {
     if (shouldThrottleRendering())
         return;
     page()->animator().scheduleVisualUpdate(this);
 }
 
 FrameLoaderClient* LocalFrame::client() const
 {
     return static_cast<FrameLoaderClient*>(Frame::client());
 }
 
 PluginData* LocalFrame::pluginData() const
 {
     if (!loader().allowPlugins(NotAboutToInstantiatePlugin))
         return nullptr;
     return page()->pluginData();
 }
 
+void LocalFrame::enableWebPerfInspectorInstrumentation()

[Sami, 2016/08/17 10:40:28]

Could we have a way to disable this too?

+{
+    // Register InspectorAgent to begin observing LongTaskTiming
+    if (this->isLocalRoot()) {
+        if (!m_inspectorWebPerformanceAgent) {

[pfeldman, 2016/08/17 21:12:10]

This can become a utility static function within InspectorWebPerformanceAgent

+            Location* location = document()->location();
+            fprintf(stderr, "\n^^^LocalFrame::enableWebPerfInspectorInstrumentation() %s: %s!",
+                    location->hostname().ascii().data(),
+                    location->pathname().ascii().data());
+            m_inspectorWebPerformanceAgent = new InspectorWebPerfAgent(
+                InspectedFrames::create(localFrameRoot()));
+            m_instrumentingAgents->addInspectorWebPerfAgent(
+                m_inspectorWebPerformanceAgent);
+        }
+    }
+}
+
 DEFINE_WEAK_IDENTIFIER_MAP(LocalFrame);
 
 FrameNavigationDisabler::FrameNavigationDisabler(LocalFrame& frame)
     : m_frame(&frame)
 {
     m_frame->disableNavigation();
 }
 
 FrameNavigationDisabler::~FrameNavigationDisabler()
 {
     m_frame->enableNavigation();
 }
 
 ScopedFrameBlamer::ScopedFrameBlamer(LocalFrame* frame)
     : m_frame(frame)
 {
     if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
         m_frame->client()->frameBlameContext()->Enter();
 }
 
 ScopedFrameBlamer::~ScopedFrameBlamer()
 {
     if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
         m_frame->client()->frameBlameContext()->Leave();
 }
 
 } // namespace blink