Milo: Use luci-cfg for defining projects and console view.

Milo: Use luci-cfg for defining projects and console view.

* Console urls now /console/<project>/<name>
** If the name is missing, it will be "default"

BUG=632516
Committed: https://github.com/luci/luci-go/commit/16d9cb920d627eae77d9b22e4ed951a5e3effce1

[Ryan Tseng, 2016-08-11 23:39:15]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:39:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:41:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:41:08]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Precise 32 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3094cb256adaab10)
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3094cb22bd823810)

[Ryan Tseng, 2016-08-11 23:41:58]

Remove config.go

[Ryan Tseng, 2016-08-11 23:42:00]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:42:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-11 23:42:20]

Description was changed from

==========
Milo: Use luci-cfg for defining projects and console view.

BUG=632516
==========

to

==========
Milo: Use luci-cfg for defining projects and console view.

* Console urls now /console/<project>/<name>
** If the name is missing, it will be "default"

BUG=632516
==========

[Ryan Tseng, 2016-08-11 23:42:20]

hinoka@google.com changed reviewers:
+ estaab@chromium.org, nodir@chromium.org

[Ryan Tseng, 2016-08-11 23:42:30]

Rebase

[Ryan Tseng, 2016-08-11 23:42:31]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-11 23:47:45]

Ptal

This CL does not include ACL support, that'll come in the next CL

[commit-bot: I haz the power, 2016-08-11 23:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:49:28]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-08-11 23:54:57]

Actually add an endpoint

[Ryan Tseng, 2016-08-11 23:54:58]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:55:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-11 23:55:54]

Also i did use "logging" instead of "log".  I'm going to file another CL to
change the rest of the app to use "logging" instead of "log" because it's
friendlier with :GoImports

[commit-bot: I haz the power, 2016-08-12 00:01:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:01:58]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-08-16 00:17:05]

estaab ptal

[Ryan Tseng, 2016-08-16 23:22:52]

hinoka@google.com changed reviewers:
- nodir@chromium.org

[Ryan Tseng, 2016-08-16 23:22:53]

ping?

[estaab, 2016-08-18 15:51:46]

https://codereview.chromium.org/2238883003/diff/60001/milo/appengine/console/...
File milo/appengine/console/console.go (right):

https://codereview.chromium.org/2238883003/diff/60001/milo/appengine/console/...
milo/appengine/console/console.go:38: // If the user is not a reader of any of
of the builders returned,
Can you move the TODO up here so it's clear that it doesn't currently do it?

https://codereview.chromium.org/2238883003/diff/60001/milo/appengine/console/...
milo/appengine/console/console.go:42: name = "default"
Can you mention something about this? What is the behavior of the default
project?

[Ryan Tseng, 2016-08-18 17:54:20]

comments

[Ryan Tseng, 2016-08-18 17:54:21]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 17:54:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:09:03]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-08-18 18:12:45]

https://codereview.chromium.org/2238883003/diff/60001/milo/appengine/console/...
File milo/appengine/console/console.go (right):

https://codereview.chromium.org/2238883003/diff/60001/milo/appengine/console/...
milo/appengine/console/console.go:38: // If the user is not a reader of any of
of the builders returned,
On 2016/08/18 15:51:46, estaab wrote:
> Can you move the TODO up here so it's clear that it doesn't currently do it?

Done.

https://codereview.chromium.org/2238883003/diff/60001/milo/appengine/console/...
milo/appengine/console/console.go:42: name = "default"
On 2016/08/18 15:51:46, estaab wrote:
> Can you mention something about this? What is the behavior of the default
> project?

Done.

[estaab, 2016-08-18 23:19:38]

lgtm

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/console/...
File milo/appengine/console/console.go (right):

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/console/...
milo/appengine/console/console.go:41: // default console for that project (named
"default") will be looked up.
Should we 302 redirect to the actual console url so there's only one true url
for a given console?

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/frontend...
File milo/appengine/frontend/milo.go (right):

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/frontend...
milo/appengine/frontend/milo.go:32: r.GET("/console/:project/:name", basemw,
settings.Wrap(console.Console{}))
I really like the scheme.

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/settings...
File milo/appengine/settings/config.go (right):

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/settings...
milo/appengine/settings/config.go:106: // TODO(hinoka): First, get it from
Memcache
Doesn't gae have an automatic memcaching layer? Maybe I'm totally mistaken :P

https://codereview.chromium.org/2238883003/diff/80001/milo/common/config/proj...
File milo/common/config/project.proto (right):

https://codereview.chromium.org/2238883003/diff/80001/milo/common/config/proj...
milo/common/config/project.proto:27: message Console {
Cool, seems simple enough.

[Ryan Tseng, 2016-08-18 23:52:30]

review

[Ryan Tseng, 2016-08-18 23:52:31]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 23:52:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-18 23:55:30]

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/console/...
File milo/appengine/console/console.go (right):

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/console/...
milo/appengine/console/console.go:41: // default console for that project (named
"default") will be looked up.
On 2016/08/18 23:19:37, estaab wrote:
> Should we 302 redirect to the actual console url so there's only one true url
> for a given console?

Hm okay.  In that case i'll name it something nicer, like "main"

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/frontend...
File milo/appengine/frontend/milo.go (right):

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/frontend...
milo/appengine/frontend/milo.go:32: r.GET("/console/:project/:name", basemw,
settings.Wrap(console.Console{}))
On 2016/08/18 23:19:37, estaab wrote:
> I really like the scheme.

:D

Nodir convinced it it was better for projects to have their own namespace, and
use a default console as a shorthand.

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/settings...
File milo/appengine/settings/config.go (right):

https://codereview.chromium.org/2238883003/diff/80001/milo/appengine/settings...
milo/appengine/settings/config.go:106: // TODO(hinoka): First, get it from
Memcache
On 2016/08/18 23:19:37, estaab wrote:
> Doesn't gae have an automatic memcaching layer? Maybe I'm totally mistaken :P

Yeah it does... removing now.

https://codereview.chromium.org/2238883003/diff/80001/milo/common/config/proj...
File milo/common/config/project.proto (right):

https://codereview.chromium.org/2238883003/diff/80001/milo/common/config/proj...
milo/common/config/project.proto:27: message Console {
On 2016/08/18 23:19:37, estaab wrote:
> Cool, seems simple enough.

Acknowledged.

[Ryan Tseng, 2016-08-18 23:55:35]

The CQ bit was unchecked by hinoka@google.com

[Ryan Tseng, 2016-08-18 23:55:38]

The CQ bit was checked by hinoka@google.com

[Ryan Tseng, 2016-08-18 23:55:39]

The patchset sent to the CQ was uploaded after l-g-t-m from estaab@chromium.org
Link to the patchset: https://codereview.chromium.org/2238883003/#ps100001
(title: "review")

[commit-bot: I haz the power, 2016-08-18 23:55:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 00:01:25]

Description was changed from

==========
Milo: Use luci-cfg for defining projects and console view.

* Console urls now /console/<project>/<name>
** If the name is missing, it will be "default"

BUG=632516
==========

to

==========
Milo: Use luci-cfg for defining projects and console view.

* Console urls now /console/<project>/<name>
** If the name is missing, it will be "default"

BUG=632516

Committed:
https://github.com/luci/luci-go/commit/16d9cb920d627eae77d9b22e4ed951a5e3effce1
==========

[commit-bot: I haz the power, 2016-08-19 00:01:27]

Committed patchset #6 (id:100001) as
https://github.com/luci/luci-go/commit/16d9cb920d627eae77d9b22e4ed951a5e3effce1