Milo: Use luci-cfg for defining projects and console view.

milo/appengine/console/console.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package console
 
 import (
         "fmt"
         "strings"
 
         "github.com/luci/luci-go/common/clock"
         log "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/milo/api/resp"
         "github.com/luci/luci-go/milo/appengine/backend/git"
         "github.com/luci/luci-go/milo/appengine/buildbot"
+        "github.com/luci/luci-go/milo/appengine/settings"
+        "github.com/luci/luci-go/milo/common/config"
         "golang.org/x/net/context"
 )
 
 // Returns results of build[commit_index][builder_index]
 func GetConsoleBuilds(
         c context.Context, module string,
         builders []resp.BuilderRef, commits []string) (
         [][]*resp.ConsoleBuild, error) {
 
         switch module {
         case "buildbot":
                 return buildbot.GetConsoleBuilds(c, builders, commits)
         // The case for buildbucket and dm goes here.
         default:
                 panic(fmt.Errorf("Unrecognized module %s", module))
         }
 }
 
-func console(c context.Context, def *ConsoleDef) (*resp.Console, error) {
-        tStart := clock.Now(c)
-        // Lookup Commits.  For this hack, we're just gonna hardcode src.git
-        commits, err := git.GetCommits(c, def.Repository, def.Branch, 25)
+// getConsoleDef finds the console definition as defined by any project.
+// If the user is not a reader of the project, this will return a 404.
+// If the user is not a reader of any of of the builders returned,

[estaab, 2016/08/18 15:51:46]

Can you move the TODO up here so it's clear that it doesn't currently do it?

[Ryan Tseng, 2016/08/18 18:12:45]

Done.

+// that builder will be removed from list of results.
+func getConsoleDef(c context.Context, project, name string) (*config.Console, error) {
+        if name == "" {
+                name = "default"

[estaab, 2016/08/18 15:51:46]

Can you mention something about this? What is the behavior of the default
project?

[Ryan Tseng, 2016/08/18 18:12:45]

Done.

+        }
+        cs, err := settings.GetConsole(c, project, name)
         if err != nil {
                 return nil, err
         }
+        // TODO(hinoka): Remove builders that the user does not have access to.
+        return cs, nil
+}
+
+func console(c context.Context, project, name string) (*resp.Console, error) {
+        tStart := clock.Now(c)
+        def, err := getConsoleDef(c, project, name)
+        if err != nil {
+                return nil, err
+        }
+        commits, err := git.GetCommits(c, def.RepoURL, def.Branch, 25)
+        if err != nil {
+                return nil, err
+        }
         tGitiles := clock.Now(c)
         log.Debugf(c, "Loading commits took %s.", tGitiles.Sub(tStart))
         commitNames := make([]string, len(commits))
         for i, commit := range commits {
                 commitNames[i] = commit.Revision
         }
 
         // HACK(hinoka): This only supports buildbot....
         builders := make([]resp.BuilderRef, len(def.Builders))
         for i, b := range def.Builders {
@@ skipping 15 matching lines @@
         }
 
         cs := &resp.Console{
                 Name:       def.Name,
                 Commit:     ccb,
                 BuilderRef: builders,
         }
 
         return cs, nil
 }