Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2238763002: chromeos: Update update_engine D-Bus availability code. (Closed)

Created:
4 years, 4 months ago by Daniel Erat
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Update update_engine D-Bus availability code. Rename a method in UpdateEngineClient and add an error message to reflect the way that dbus::ObjectProxy::WaitForServiceToBeAvailable() actually works. BUG=636554 TBR=stevenjb@chromium.org Committed: https://crrev.com/08c5efaa7689e8a51c780ec117adaed7cd035842 Cr-Commit-Position: refs/heads/master@{#411247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chromeos/dbus/update_engine_client.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Daniel Erat
4 years, 4 months ago (2016-08-11 02:30:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238763002/1
4 years, 4 months ago (2016-08-11 02:32:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 03:19:46 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 03:21:55 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/08c5efaa7689e8a51c780ec117adaed7cd035842
Cr-Commit-Position: refs/heads/master@{#411247}

Powered by Google App Engine
This is Rietveld 408576698