Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chromeos/dbus/update_engine_client.cc

Issue 2238763002: chromeos: Update update_engine D-Bus availability code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/update_engine_client.cc
diff --git a/chromeos/dbus/update_engine_client.cc b/chromeos/dbus/update_engine_client.cc
index 2abd1b02ab316b2b58f840494d02327486be7447..b2ae229eab9d02b940990aa22b1c3567415965d8 100644
--- a/chromeos/dbus/update_engine_client.cc
+++ b/chromeos/dbus/update_engine_client.cc
@@ -231,18 +231,20 @@ class UpdateEngineClientImpl : public UpdateEngineClient {
base::Bind(&UpdateEngineClientImpl::StatusUpdateConnected,
weak_ptr_factory_.GetWeakPtr()));
update_engine_proxy_->WaitForServiceToBeAvailable(
- base::Bind(&UpdateEngineClientImpl::OnProxyAvailabilityChanged,
+ base::Bind(&UpdateEngineClientImpl::OnServiceInitiallyAvailable,
weak_ptr_factory_.GetWeakPtr()));
}
private:
- void OnProxyAvailabilityChanged(bool service_is_available) {
+ void OnServiceInitiallyAvailable(bool service_is_available) {
if (service_is_available) {
// Get update engine status for the initial status. Update engine won't
// send StatusUpdate signal unless there is a status change. If chrome
// crashes after UPDATE_STATUS_UPDATED_NEED_REBOOT status is set,
// restarted chrome would not get this status. See crbug.com/154104.
GetUpdateEngineStatus();
+ } else {
+ LOG(ERROR) << "Failed to wait for D-Bus service to become available";
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698