Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4742)

Unified Diff: chrome/browser/web_dev_style/html_checker_test.py

Issue 2238613003: web_dev_style: make <label for=""> check ignore <paper-tooltip for=""> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_dev_style/html_checker.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_dev_style/html_checker_test.py
diff --git a/chrome/browser/web_dev_style/html_checker_test.py b/chrome/browser/web_dev_style/html_checker_test.py
index 6767ba401a467070a5ea1330300ba125e68e3214..1a37f46ac3449c96f35331649f88d063cc1f7420 100755
--- a/chrome/browser/web_dev_style/html_checker_test.py
+++ b/chrome/browser/web_dev_style/html_checker_test.py
@@ -170,10 +170,10 @@ class HtmlCheckerTest(SuperMoxTestBase):
def testLabelCheckFails(self):
lines = [
- ' for="abc"',
- "for= ",
- " \tfor= ",
- " for="
+ ' <label for="abc"',
+ " <label for= ",
+ " <label\tfor= ",
+ ' <label\n blah="1" blee="3"\n for="goop"',
]
for line in lines:
self.ShouldFailCheck(line, self.checker.LabelCheck)
@@ -183,6 +183,7 @@ class HtmlCheckerTest(SuperMoxTestBase):
' my-for="abc" ',
' myfor="abc" ',
" <for",
+ ' <paper-tooltip for="id-name"',
]
for line in lines:
self.ShouldPassCheck(line, self.checker.LabelCheck)
« no previous file with comments | « chrome/browser/web_dev_style/html_checker.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698