chrome/browser/web_dev_style/html_checker.py - Issue 2238613003: web_dev_style: make <label for=""> check ignore <paper-tooltip for="">

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_dev_style/html_checker.py

Issue 2238613003: web_dev_style: make <label for=""> check ignore <paper-tooltip for=""> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/web_dev_style/html_checker.py

diff --git a/chrome/browser/web_dev_style/html_checker.py b/chrome/browser/web_dev_style/html_checker.py

index 0c8df98ee55b7a1f6cd16da8557b1e11c79866ac..bfa063d52d3f16fa2732db87e3f2dd0d8d12a83c 100644

--- a/chrome/browser/web_dev_style/html_checker.py

+++ b/chrome/browser/web_dev_style/html_checker.py

@@ -67,8 +67,9 @@ class HtmlChecker(object):

def LabelCheck(self, line_number, line):

regex = self.input_api.re.compile("""

- (?:^|\s) # start of line or whitespace

- (for=) # for=

+ (?:^|\s) # start of line or whitespace

+ <label[^>]+? # <label tag

+ (for=) # for=

""",

self.input_api.re.VERBOSE)

return regex_check.RegexCheck(self.input_api.re, line_number, line, regex,

« no previous file with comments | « no previous file | chrome/browser/web_dev_style/html_checker_test.py » ('j') | no next file with comments »