Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: chrome/browser/web_dev_style/html_checker.py

Issue 2238613003: web_dev_style: make <label for=""> check ignore <paper-tooltip for=""> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/web_dev_style/html_checker_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_dev_style/html_checker.py
diff --git a/chrome/browser/web_dev_style/html_checker.py b/chrome/browser/web_dev_style/html_checker.py
index 0c8df98ee55b7a1f6cd16da8557b1e11c79866ac..bfa063d52d3f16fa2732db87e3f2dd0d8d12a83c 100644
--- a/chrome/browser/web_dev_style/html_checker.py
+++ b/chrome/browser/web_dev_style/html_checker.py
@@ -67,8 +67,9 @@ class HtmlChecker(object):
def LabelCheck(self, line_number, line):
regex = self.input_api.re.compile("""
- (?:^|\s) # start of line or whitespace
- (for=) # for=
+ (?:^|\s) # start of line or whitespace
+ <label[^>]+? # <label tag
+ (for=) # for=
""",
self.input_api.re.VERBOSE)
return regex_check.RegexCheck(self.input_api.re, line_number, line, regex,
« no previous file with comments | « no previous file | chrome/browser/web_dev_style/html_checker_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698