Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2238603002: Introduce AfterStartupTaskUtils::Runner for callsites that want to use AfterStartupTaskUtils but ne… (Closed)

Created:
4 years, 4 months ago by gab
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@b9_sequenced_worker_pool_redirection
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce AfterStartupTaskUtils::Runner for callsites that want to use AfterStartupTaskUtils but need a TaskRunner. BUG=636518 Committed: https://crrev.com/27e6d33fae535f032d7abcad36a71e690ab0ae55 Cr-Commit-Position: refs/heads/master@{#411312}

Patch Set 1 #

Patch Set 2 : explicit dtor #

Patch Set 3 : merge up to r411308 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -13 lines) Patch
M chrome/browser/after_startup_task_utils.h View 1 2 1 chunk +26 lines, -10 lines 0 comments Download
M chrome/browser/after_startup_task_utils.cc View 1 2 2 chunks +24 lines, -3 lines 0 comments Download
M chrome/browser/after_startup_task_utils_unittest.cc View 2 1 chunk +26 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
gab
sky PTAL, thanks!
4 years, 4 months ago (2016-08-10 20:55:43 UTC) #2
sky
LGTM
4 years, 4 months ago (2016-08-10 22:22:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238603002/20001
4 years, 4 months ago (2016-08-11 12:27:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/249538) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-11 12:29:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238603002/40001
4 years, 4 months ago (2016-08-11 12:36:09 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-11 13:15:49 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 13:17:27 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/27e6d33fae535f032d7abcad36a71e690ab0ae55
Cr-Commit-Position: refs/heads/master@{#411312}

Powered by Google App Engine
This is Rietveld 408576698