Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2236993004: Annotate PostTaskAndReplyRelay as being self-managed and potentially leaked in PostTaskAndReplyImpl. (Closed)

Created:
4 years, 4 months ago by gab
Modified:
4 years, 4 months ago
Reviewers:
danakj, fdoray
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@b1_afterstartup_runner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Annotate PostTaskAndReplyRelay as being self-managed and potentially leaked in PostTaskAndReplyImpl. The leaks occur on shutdown when the |task| either hasn't been processed yet or doesn't have time to post back to the origin sequence before it stops receiving or processing tasks. Those leaks being racy with shutdown, this has resulted in numerous flaky LSan failures resulting in suppressions over the years. BUG=602964 Committed: https://crrev.com/3f00cf8a85b52702c4d0714a154a17d00006382e Cr-Commit-Position: refs/heads/master@{#413803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -45 lines) Patch
M base/threading/post_task_and_reply_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 5 chunks +0 lines, -45 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 28 (14 generated)
gab
Lei PTAL and CQ if it LGTYs (bots are green and I'm heading out for ...
4 years, 4 months ago (2016-08-15 21:01:01 UTC) #6
gab
s/Lei/Dana (Lei's just back and chasing a P0)
4 years, 4 months ago (2016-08-15 21:05:26 UTC) #8
danakj
LGT
4 years, 4 months ago (2016-08-15 21:12:13 UTC) #9
danakj
On 2016/08/15 21:12:13, danakj wrote: > LGT M
4 years, 4 months ago (2016-08-15 21:12:20 UTC) #10
danakj
lgtm
4 years, 4 months ago (2016-08-15 21:12:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236993004/1
4 years, 4 months ago (2016-08-15 21:33:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/262069)
4 years, 4 months ago (2016-08-15 22:26:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236993004/1
4 years, 4 months ago (2016-08-20 15:07:11 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126552)
4 years, 4 months ago (2016-08-20 15:50:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236993004/1
4 years, 4 months ago (2016-08-21 05:57:28 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126674)
4 years, 4 months ago (2016-08-21 06:41:30 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236993004/1
4 years, 4 months ago (2016-08-23 16:30:15 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 19:06:19 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 19:09:29 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f00cf8a85b52702c4d0714a154a17d00006382e
Cr-Commit-Position: refs/heads/master@{#413803}

Powered by Google App Engine
This is Rietveld 408576698