|
|
Created:
4 years, 4 months ago by gab Modified:
4 years, 4 months ago CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@b1_afterstartup_runner Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAnnotate PostTaskAndReplyRelay as being self-managed and potentially leaked in PostTaskAndReplyImpl.
The leaks occur on shutdown when the |task| either hasn't been processed
yet or doesn't have time to post back to the origin sequence before
it stops receiving or processing tasks.
Those leaks being racy with shutdown, this has resulted in numerous
flaky LSan failures resulting in suppressions over the years.
BUG=602964
Committed: https://crrev.com/3f00cf8a85b52702c4d0714a154a17d00006382e
Cr-Commit-Position: refs/heads/master@{#413803}
Patch Set 1 #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 28 (14 generated)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
gab@chromium.org changed reviewers: + thestig@chromium.org
Lei PTAL and CQ if it LGTYs (bots are green and I'm heading out for 2 weeks).
gab@chromium.org changed reviewers: + danakj@chromium.org - thestig@chromium.org
s/Lei/Dana (Lei's just back and chasing a P0)
LGT
On 2016/08/15 21:12:13, danakj wrote: > LGT M
lgtm
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Annotate PostTaskAndReplyRelay as being self-managed and potentially leaked in PostTaskAndReplyImpl. The leaks occur on shutdown when the |task| either hasn't been processed yet or doesn't have time to post back to the origin sequence before it stops receiving or processing tasks. Those leaks being racy with shutdown, this has resulted in numerous flaky LSan failures resulting in suppressions over the years. BUG=602964 ========== to ========== Annotate PostTaskAndReplyRelay as being self-managed and potentially leaked in PostTaskAndReplyImpl. The leaks occur on shutdown when the |task| either hasn't been processed yet or doesn't have time to post back to the origin sequence before it stops receiving or processing tasks. Those leaks being racy with shutdown, this has resulted in numerous flaky LSan failures resulting in suppressions over the years. BUG=602964 Committed: https://crrev.com/3f00cf8a85b52702c4d0714a154a17d00006382e Cr-Commit-Position: refs/heads/master@{#413803} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3f00cf8a85b52702c4d0714a154a17d00006382e Cr-Commit-Position: refs/heads/master@{#413803} |