chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc - Issue 2238543002: Instrument parser blocking script execution time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

index 6cab290a8deaf4327b79de75a7736d3a054fc0ec..f766b71b7986b4fafaaa3df9660b378f5d7e2943 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

@@ -54,6 +54,8 @@ IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NewPage) {

histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1);

histogram_tester_.ExpectTotalCount(

internal::kHistogramParseBlockedOnScriptLoad, 1);

+ histogram_tester_.ExpectTotalCount(

+ internal::kHistogramParseBlockedOnScriptExecution, 1);

}

IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,