Make browsing_data component a layered component

Make browsing_data component a layered component

The browsing_data component will have the following structure
   - core/
      - counters/
         - counters files
      - util files
   - content/
     - conditional_cache_deletion_helper.*
     - storage_partition_http_cache_data_remover.*

BUG=620317
Committed: https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f
Cr-Commit-Position: refs/heads/master@{#406517}

[ioanap, 2016-07-08 09:33:36]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 09:34:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 11:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 11:17:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ioanap, 2016-07-11 13:43:51]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 13:44:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 14:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 14:16:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ioanap, 2016-07-12 09:12:27]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 09:12:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 11:14:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 11:14:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ioanap, 2016-07-13 12:03:50]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 12:04:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ioanap, 2016-07-13 12:09:52]

Description was changed from

==========
Separate build target and dependencies in components/browsing_data




BUG=
==========

to

==========
Exclude files and incompatible dependencies from components/browsing_data when
building for iOS

Exclude dependency on content/public/browser and the files that need it from
components/browsing_data when building for iOS. Those files are:
    - conditional_cache_deletion_helper.cc
    - storage_partition_http_cache_data_remover.cc 

BUG=620317
==========

[commit-bot: I haz the power, 2016-07-13 13:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 13:18:59]

Dry run: This issue passed the CQ dry run.

[ioanap, 2016-07-13 13:26:08]

ioanap@google.com changed reviewers:
+ msramek@chromium.org

[ioanap, 2016-07-13 13:26:09]

Please have a look!

Thank you,
Ioana

[blundell, 2016-07-13 13:27:39]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-07-13 13:27:40]

drive-by: The proper way to structure this change is to turn the browsing_data
component into a layered component:

https://www.chromium.org/developers/design-documents/structure-of-layered-com...

Happy to help if you need more info!

[sdefresne, 2016-07-13 13:30:59]

On 2016/07/13 13:27:40, blundell wrote:
> drive-by: The proper way to structure this change is to turn the browsing_data
> component into a layered component:
> 
>
https://www.chromium.org/developers/design-documents/structure-of-layered-com...
> 
> Happy to help if you need more info!

+1

[ioanap, 2016-07-13 14:35:25]

On 2016/07/13 13:30:59, sdefresne wrote:
> On 2016/07/13 13:27:40, blundell wrote:
> > drive-by: The proper way to structure this change is to turn the
browsing_data
> > component into a layered component:
> > 
> >
>
https://www.chromium.org/developers/design-documents/structure-of-layered-com...
> > 
> > Happy to help if you need more info!
> 
> +1

Oh, alright, I didn’t realize I needed to do that. Thank you for pointing me to
the doc! In this case, the structure could maybe look like this:
-core/
    -counters/ 
          -The counters files, since they will be used on all platforms
    -Utils files, also used on all platforms
-content/
   -browser/
      -conditional_cache_deletion_helper.*
      -storage_partition_http_cache_data_remover.* 

What do you think ?

[blundell, 2016-07-13 14:48:03]

On 2016/07/13 14:35:25, ioanap wrote:
> On 2016/07/13 13:30:59, sdefresne wrote:
> > On 2016/07/13 13:27:40, blundell wrote:
> > > drive-by: The proper way to structure this change is to turn the
> browsing_data
> > > component into a layered component:
> > > 
> > >
> >
>
https://www.chromium.org/developers/design-documents/structure-of-layered-com...
> > > 
> > > Happy to help if you need more info!
> > 
> > +1
> 
> Oh, alright, I didn’t realize I needed to do that. Thank you for pointing me
to
> the doc! In this case, the structure could maybe look like this:
> -core/
>     -counters/ 
>           -The counters files, since they will be used on all platforms
>     -Utils files, also used on all platforms
> -content/
>    -browser/
>       -conditional_cache_deletion_helper.*
>       -storage_partition_http_cache_data_remover.* 
> 
> What do you think ?

I'm not sure you need the subdirs below core/ and content/. In particular you
would only need the browser/ subdir if you have multiprocess concerns (i.e., a
division of code into browser-specific, renderer-specific, and/or common code).

The basic division between core/ and content/ is exactly the right idea.

[ioanap, 2016-07-13 15:03:34]

On 2016/07/13 14:48:03, blundell wrote:
> On 2016/07/13 14:35:25, ioanap wrote:
> > On 2016/07/13 13:30:59, sdefresne wrote:
> > > On 2016/07/13 13:27:40, blundell wrote:
> > > > drive-by: The proper way to structure this change is to turn the
> > browsing_data
> > > > component into a layered component:
> > > > 
> > > >
> > >
> >
>
https://www.chromium.org/developers/design-documents/structure-of-layered-com...
> > > > 
> > > > Happy to help if you need more info!
> > > 
> > > +1
> > 
> > Oh, alright, I didn’t realize I needed to do that. Thank you for pointing me
> to
> > the doc! In this case, the structure could maybe look like this:
> > -core/
> >     -counters/ 
> >           -The counters files, since they will be used on all platforms
> >     -Utils files, also used on all platforms
> > -content/
> >    -browser/
> >       -conditional_cache_deletion_helper.*
> >       -storage_partition_http_cache_data_remover.* 
> > 
> > What do you think ?
> 
> I'm not sure you need the subdirs below core/ and content/. In particular you
> would only need the browser/ subdir if you have multiprocess concerns (i.e., a
> division of code into browser-specific, renderer-specific, and/or common
code).
> 
> The basic division between core/ and content/ is exactly the right idea.

Thank you for your input !

I talked to Martin and although the "counters" subdir is not needed, we'd like
to keep it for cleanness .

[blundell, 2016-07-13 15:04:30]

On 2016/07/13 15:03:34, ioanap wrote:
> On 2016/07/13 14:48:03, blundell wrote:
> > On 2016/07/13 14:35:25, ioanap wrote:
> > > On 2016/07/13 13:30:59, sdefresne wrote:
> > > > On 2016/07/13 13:27:40, blundell wrote:
> > > > > drive-by: The proper way to structure this change is to turn the
> > > browsing_data
> > > > > component into a layered component:
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://www.chromium.org/developers/design-documents/structure-of-layered-com...
> > > > > 
> > > > > Happy to help if you need more info!
> > > > 
> > > > +1
> > > 
> > > Oh, alright, I didn’t realize I needed to do that. Thank you for pointing
me
> > to
> > > the doc! In this case, the structure could maybe look like this:
> > > -core/
> > >     -counters/ 
> > >           -The counters files, since they will be used on all platforms
> > >     -Utils files, also used on all platforms
> > > -content/
> > >    -browser/
> > >       -conditional_cache_deletion_helper.*
> > >       -storage_partition_http_cache_data_remover.* 
> > > 
> > > What do you think ?
> > 
> > I'm not sure you need the subdirs below core/ and content/. In particular
you
> > would only need the browser/ subdir if you have multiprocess concerns (i.e.,
a
> > division of code into browser-specific, renderer-specific, and/or common
> code).
> > 
> > The basic division between core/ and content/ is exactly the right idea.
> 
> Thank you for your input !
> 
> I talked to Martin and although the "counters" subdir is not needed, we'd like
> to keep it for cleanness .

Yep, that one's up to you.

[ioanap, 2016-07-14 12:48:49]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 12:49:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 12:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 12:57:56]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[ioanap, 2016-07-14 14:03:39]

Patchset #7 (id:120001) has been deleted

[ioanap, 2016-07-14 15:51:45]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 15:52:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 16:12:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 16:12:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[ioanap, 2016-07-15 10:49:13]

Description was changed from

==========
Exclude files and incompatible dependencies from components/browsing_data when
building for iOS

Exclude dependency on content/public/browser and the files that need it from
components/browsing_data when building for iOS. Those files are:
    - conditional_cache_deletion_helper.cc
    - storage_partition_http_cache_data_remover.cc 

BUG=620317
==========

to

==========
Make browsing_data component a layered component

The browsing_data component will have the following structure
   - core/
      - counters/ 
         - counters files
      - util files
   - content/
     - conditional_cache_deletion_helper.*
     - storage_partition_http_cache_data_remover.* 
    


BUG=620317
==========

[ioanap, 2016-07-15 11:32:18]

ioanap@google.com changed reviewers:
+ bauerb@chromium.org, dbeam@chromium.org, lfg@chromium.org, msw@chromium.org,
palmer@chromium.org, rdevlin.cronin@chromium.org

[ioanap, 2016-07-15 11:32:20]

Hi,

Please have a look!

dbeam@chromium.org: Please review changes in 
c/b/ui/webui/

palmer@chromium.org: Please review changes in 
c/b/ssl/

bauerb@chromium.org: Please review changes in 
c/android/
c/b/android/

rdevlin.cronin@chromium.org: Please review changes in 
extensions/
c/b/extensions/

msw@chromium.org: Please review changes in 
browser_ui_prefs.cc

lfg@chromium.org: Please review changes in 
chrome_web_view_guest_delegate.cc

Thanks,
Ioana

[msramek, 2016-07-15 11:45:47]

c/b/browsing_data LGTM

components/browsing_data LGTM if Colin is happy

[lfg, 2016-07-15 14:03:15]

chrome_web_view_guest_delegate.cc lgtm

[Devlin, 2016-07-15 14:53:54]

extensions lgtm

[msw, 2016-07-15 15:35:48]

browser_ui_prefs.cc lgtm

[palmer, 2016-07-16 00:31:03]

chrome/browser/ssl LGTM.

[Dan Beam, 2016-07-16 00:36:34]

rs lgtm

[blundell, 2016-07-18 06:26:01]

//components lgtm, thanks

[Bernhard Bauer, 2016-07-18 14:38:19]

LGTM. FTR, the trivial parts of this change (updating include paths) are okay to
TBR if the overall change has been approved.

[ioanap, 2016-07-18 15:29:49]

Okay, I see! Thank you! :)

[ioanap, 2016-07-18 15:30:19]

ioanap@google.com changed reviewers:
+ jochen@chromium.org

[ioanap, 2016-07-18 15:30:20]

jochen@chromium.org: Please review changes in 

c/b/BUILD.gn

[jochen (gone - plz use gerrit), 2016-07-19 12:20:17]

lgtm

[ioanap, 2016-07-19 12:27:48]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 12:28:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 13:27:36]

Dry run: This issue passed the CQ dry run.

[ioanap, 2016-07-19 13:28:06]

The CQ bit was checked by ioanap@google.com

[commit-bot: I haz the power, 2016-07-19 13:28:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 13:36:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ioanap, 2016-07-19 14:06:56]

ioanap@google.com changed reviewers:
+ mmenke@chromium.org

[ioanap, 2016-07-19 14:06:57]

+ mmenke for dependency on net/ moved from components/browsing_data/DEPS to
components/browsing_data/content/DEPS

[mmenke, 2016-07-19 14:08:43]

On 2016/07/19 14:06:57, ioanap wrote:
> + mmenke for dependency on net/ moved from components/browsing_data/DEPS to
> components/browsing_data/content/DEPS

LGTM, rubberstamp, based on that description.

[ioanap, 2016-07-20 08:16:34]

The CQ bit was checked by ioanap@google.com

[commit-bot: I haz the power, 2016-07-20 08:16:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ioanap, 2016-07-20 08:18:12]

The CQ bit was unchecked by ioanap@google.com

[ioanap, 2016-07-20 08:19:34]

The CQ bit was checked by ioanap@google.com

[commit-bot: I haz the power, 2016-07-20 08:20:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 08:25:05]

Description was changed from

==========
Make browsing_data component a layered component

The browsing_data component will have the following structure
   - core/
      - counters/ 
         - counters files
      - util files
   - content/
     - conditional_cache_deletion_helper.*
     - storage_partition_http_cache_data_remover.* 
    


BUG=620317
==========

to

==========
Make browsing_data component a layered component

The browsing_data component will have the following structure
   - core/
      - counters/ 
         - counters files
      - util files
   - content/
     - conditional_cache_deletion_helper.*
     - storage_partition_http_cache_data_remover.* 
    


BUG=620317
==========

[commit-bot: I haz the power, 2016-07-20 08:25:07]

Committed patchset #12 (id:240001)

[commit-bot: I haz the power, 2016-07-20 08:26:32]

Description was changed from

==========
Make browsing_data component a layered component

The browsing_data component will have the following structure
   - core/
      - counters/ 
         - counters files
      - util files
   - content/
     - conditional_cache_deletion_helper.*
     - storage_partition_http_cache_data_remover.* 
    


BUG=620317
==========

to

==========
Make browsing_data component a layered component

The browsing_data component will have the following structure
   - core/
      - counters/
         - counters files
      - util files
   - content/
     - conditional_cache_deletion_helper.*
     - storage_partition_http_cache_data_remover.*

BUG=620317

Committed: https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f
Cr-Commit-Position: refs/heads/master@{#406517}
==========

[commit-bot: I haz the power, 2016-07-20 08:26:34]

Patchset 12 (id:??) landed as
https://crrev.com/b94192650ba11fee85a268cd2874df06f0ee8e7f
Cr-Commit-Position: refs/heads/master@{#406517}