Additional fixes to zero_termination_test

Additional fixes to zero_termination_test

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/02fa5aad8ef05bd057e5cd8fc74ebc45d5fe26aa

[Siggi Cherem (dart-lang), 2016-08-12 20:26:36]

sigmund@google.com changed reviewers:
+ sra@google.com, whesse@google.com

[Siggi Cherem (dart-lang), 2016-08-12 20:26:37]

https://codereview.chromium.org/2238353002/diff/1/tests/compiler/dart2js/zero...
File tests/compiler/dart2js/zero_termination_test.dart (left):

https://codereview.chromium.org/2238353002/diff/1/tests/compiler/dart2js/zero...
tests/compiler/dart2js/zero_termination_test.dart:51: String command =
path.join(path.dirname(executable), 'dart2js');
this was dead code.

https://codereview.chromium.org/2238353002/diff/1/tests/compiler/dart2js/zero...
File tests/compiler/dart2js/zero_termination_test.dart (right):

https://codereview.chromium.org/2238353002/diff/1/tests/compiler/dart2js/zero...
tests/compiler/dart2js/zero_termination_test.dart:54: if (Platform.packageRoot
!= null) {
this addresses Bill's comments from the other CL.

[sra1, 2016-08-12 21:32:40]

lgtm

[Siggi Cherem (dart-lang), 2016-08-12 21:33:28]

Description was changed from

==========
Additional fixes to zero_termination_test

BUG=
==========

to

==========
Additional fixes to zero_termination_test

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/02fa5aad8ef05bd057e5cd8fc74ebc45d5fe26aa
==========

[Siggi Cherem (dart-lang), 2016-08-12 21:33:29]

Committed patchset #1 (id:1) manually as
02fa5aad8ef05bd057e5cd8fc74ebc45d5fe26aa (presubmit successful).

[Bill Hesse, 2016-08-15 15:48:36]

lgtm

https://codereview.chromium.org/2238353002/diff/1/tests/compiler/dart2js/zero...
File tests/compiler/dart2js/zero_termination_test.dart (right):

https://codereview.chromium.org/2238353002/diff/1/tests/compiler/dart2js/zero...
tests/compiler/dart2js/zero_termination_test.dart:54: if (Platform.packageRoot
!= null) {
On 2016/08/12 20:26:37, Siggi Cherem (dart-lang) wrote:
> this addresses Bill's comments from the other CL.

Acknowledged.