Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tests/compiler/dart2js/zero_termination_test.dart

Issue 2238353002: Additional fixes to zero_termination_test (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/zero_termination_test.dart
diff --git a/tests/compiler/dart2js/zero_termination_test.dart b/tests/compiler/dart2js/zero_termination_test.dart
index 9581e48a64bb036ac8c731716672e3c3ac58429a..3d07b7d01f86beceb9399ff910f12c53f63979d5 100644
--- a/tests/compiler/dart2js/zero_termination_test.dart
+++ b/tests/compiler/dart2js/zero_termination_test.dart
@@ -47,13 +47,17 @@ void cleanup() {
}
Future launchDart2Js(args) {
- String executable = Platform.executable;
- String command = path.join(path.dirname(executable), 'dart2js');
Siggi Cherem (dart-lang) 2016/08/12 20:26:37 this was dead code.
String dart2jsPath = path.normalize(
path.join(path.fromUri(Platform.script),
'../../../../pkg/compiler/lib/src/dart2js.dart'));
- List allArgs = ['--package-root=${Platform.packageRoot}',
- dart2jsPath]..addAll(args);
+ List allArgs = [];
+ if (Platform.packageRoot != null) {
Siggi Cherem (dart-lang) 2016/08/12 20:26:37 this addresses Bill's comments from the other CL.
Bill Hesse 2016/08/15 15:48:36 Acknowledged.
+ allArgs.add('--package-root=${Platform.packageRoot}');
+ } else if (Platform.packageConfig != null) {
+ allArgs.add('--packages=${Platform.packageConfig}');
+ }
+ allArgs.add(dart2jsPath);
+ allArgs.addAll(args);
return Process.run(Platform.executable, allArgs, stdoutEncoding: null);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698