Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2238343002: Remove apparently redundant uses of updatePageOverlays in WebViewImpl. (Closed)

Created:
4 years, 4 months ago by chrishtr
Modified:
4 years, 4 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove apparently redundant uses of updatePageOverlays in WebViewImpl. BUG=591468 Committed: https://crrev.com/f66f629cc6107328e6a445d158e7a27fa91668df Cr-Commit-Position: refs/heads/master@{#411792}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
chrishtr
4 years, 4 months ago (2016-08-12 20:39:22 UTC) #7
Xianzhu
Is there any behavior change or is this a pure cleanup? If the latter, do ...
4 years, 4 months ago (2016-08-12 20:49:08 UTC) #9
chrishtr
On 2016/08/12 at 20:49:08, wangxianzhu wrote: > Is there any behavior change or is this ...
4 years, 4 months ago (2016-08-12 20:51:45 UTC) #10
Xianzhu
lgtm. Please add some descriptions.
4 years, 4 months ago (2016-08-12 20:55:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238343002/40001
4 years, 4 months ago (2016-08-12 20:57:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 21:59:39 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 22:02:34 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f66f629cc6107328e6a445d158e7a27fa91668df
Cr-Commit-Position: refs/heads/master@{#411792}

Powered by Google App Engine
This is Rietveld 408576698