Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2238343002: Remove apparently redundant uses of updatePageOverlays in WebViewImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 749ad090c0557be7eb81acdb340eea40f2a1334f..9d1c68e21b3187e64e076eddda6196f442591b6c 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -3826,7 +3826,6 @@ void WebViewImpl::sendResizeEventAndRepaint()
m_client->widgetClient()->didInvalidateRect(damagedRect);
}
}
- updatePageOverlays();
}
void WebViewImpl::configureAutoResizeMode()
@@ -4088,8 +4087,9 @@ void WebViewImpl::layoutUpdated(WebLocalFrameImpl* webframe)
if (view->needsLayout())
view->layout();
- m_fullscreenController->didUpdateLayout();
+ updatePageOverlays();
+ m_fullscreenController->didUpdateLayout();
m_client->didUpdateLayout();
}
@@ -4272,7 +4272,7 @@ void WebViewImpl::setRootGraphicsLayer(GraphicsLayer* layer)
// We register viewport layers here since there may not be a layer
// tree view prior to this point.
registerViewportLayersWithCompositor();
- updatePageOverlays();
+
// TODO(enne): Work around page visibility changes not being
// propagated to the WebView in some circumstances. This needs to
// be refreshed here when setting a new root layer to avoid being
@@ -4293,10 +4293,12 @@ void WebViewImpl::setRootGraphicsLayer(GraphicsLayer* layer)
void WebViewImpl::invalidateRect(const IntRect& rect)
{
- if (m_layerTreeView)
+ if (m_layerTreeView) {
updateLayerTreeViewport();
- else if (m_client)
+ } else if (m_client) {
+ // This is only for WebViewPlugin.
m_client->widgetClient()->didInvalidateRect(rect);
+ }
}
PaintLayerCompositor* WebViewImpl::compositor() const
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698