scripts/slave/recipe_modules/chromium_tests/chromium_perf.py - Issue 2238243003: Merge method_counts into resource_sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

Issue 2238243003: Merge method_counts into resource_sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

index af71431a79166f1bd78e588b3ccda9dbecbd6593..c7430d4b88d26eb52a34428c03dce8e9b07d4937 100644

--- a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

@@ -47,8 +47,7 @@ def _BaseSpec(bot_type, config_name, disable_tests,

def BuildSpec(config_name, perf_id, platform, target_bits):

if platform == 'android':

- # TODO: Run sizes on Android.

- tests = []

+ tests = [steps.ResourceSizesStep()]

jbudorick 2016/08/15 15:37:43 I would prefer if you did this separately from the

agrieve 2016/09/02 18:23:18 Done.

else:

tests = [steps.SizesStep('https://chromeperf.appspot.com', perf_id)]