Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 22382003: Fix running actions and rules on make/mac (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix running actions and rules on make/mac Libraries for the target toolset are in a different location on mac, and we need to use DYLD_LIBRARY_PATH instead of LD_LIBRARY_PATH. BUG=none

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -8 lines) Patch
M pylib/gyp/generator/make.py View 1 2 5 chunks +35 lines, -8 lines 0 comments Download
A test/actions-shared-library/gyptest-prog.py View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A test/actions-shared-library/lib.h View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A test/actions-shared-library/lib.cc View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A test/actions-shared-library/shared.gyp View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
A test/actions-shared-library/tool.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
r? any idea how to test?
7 years, 4 months ago (2013-08-06 09:38:10 UTC) #1
jochen (gone - plz use gerrit)
Mark, can you have a look please?
7 years, 4 months ago (2013-08-07 05:55:19 UTC) #2
Mark Mentovai
I don’t think we set DYLD_LIBRARY_PATH for Mac builds under ninja or xcodebuild. But all ...
7 years, 4 months ago (2013-08-07 13:25:17 UTC) #3
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-14 13:03:40 UTC) #4
this only works on windows, and linux (make)

for all other configurations it fails :-/

I guess I just give up and note this down under "not supported".

Powered by Google App Engine
This is Rietveld 408576698