Allow p2p UDP packages to set DSCP

net/udp/datagram_server_socket.h

Index: net/udp/datagram_server_socket.h
diff --git a/net/udp/datagram_server_socket.h b/net/udp/datagram_server_socket.h
index f2016c0e0d04916d4e14926c54360a3b3c2e011a..ef8ef28738345312e32201189545f16c3b890dde 100644
--- a/net/udp/datagram_server_socket.h
+++ b/net/udp/datagram_server_socket.h
@@ -93,6 +93,12 @@ class NET_EXPORT DatagramServerSocket : public DatagramSocket {
   // Should be called before Bind().
   // Returns a network error code.
   virtual int SetMulticastLoopbackMode(bool loopback) = 0;
+
+  // Set the Differentiated Services Code Point.

[Sergey Ulanov, 2013/08/17 05:50:04]

nit: This is a strange way to format comments. why one sentence per line? I
understand that comments above are the same, so it would be great to reformat
them as well :-)

[hubbe, 2013/08/21 18:51:36]

Old habits die hard. :)
I reformatted this one for now.

+  // May do nothing on some platforms.
+  // Should be called before Bind().
+  // Returns a network error code.
+  virtual int SetToS(DiffServCodePoint dscp) = 0;

[Sergey Ulanov, 2013/08/17 05:50:04]

Maybe call it SetTos()? SetToS reads as "set to s" which makes no sense.

[Sergey Ulanov, 2013/08/17 05:50:04]

This seem like something that belongs to UDPServerSocket, but not here. It's
specific to datagram sockets that work over IP.

[hubbe, 2013/08/21 18:51:36]

Done.
(Although, perhaps SetDSCP would be better...)

[hubbe, 2013/08/21 18:51:36]

I can't be sure, because this class doesn't document it's intent. But from what
it looks like, DatagramServerSocket is simple an interface for UDPServerSocket
to make it easy to mock out when testing. Thus, all methods in UDPServerSocket
are overrides from this class.

If DatagramServerSocket is meant to encapsulate datagrams other than UDP/IP,
then I should probably move this function definition. (But in that case, we
should probably move the multicast stuff too, since that is also an IP level
feature, is it not?)

 };
 
 }  // namespace net