net/udp/datagram_server_socket.h - Issue 22381012: Allow p2p UDP packages to set DSCP

Side by Side Diff: net/udp/datagram_server_socket.h

Issue 22381012: Allow p2p UDP packages to set DSCP (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: extra newline removed Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« net/base/net_util.h ('K') | « net/dns/mock_mdns_socket_factory.h ('k') | net/udp/udp_server_socket.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_UDP_DATAGRAM_SERVER_SOCKET_H_	5 #ifndef NET_UDP_DATAGRAM_SERVER_SOCKET_H_

6 #define NET_UDP_DATAGRAM_SERVER_SOCKET_H_	6 #define NET_UDP_DATAGRAM_SERVER_SOCKET_H_

7	7

8 #include "net/base/completion_callback.h"	8 #include "net/base/completion_callback.h"

9 #include "net/base/net_util.h"	9 #include "net/base/net_util.h"

10 #include "net/udp/datagram_socket.h"	10 #include "net/udp/datagram_socket.h"

(...skipping 75 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
86 // Should be called before Bind().	86 // Should be called before Bind().

87 // Returns a network error code.	87 // Returns a network error code.

88 virtual int SetMulticastTimeToLive(int time_to_live) = 0;	88 virtual int SetMulticastTimeToLive(int time_to_live) = 0;

89	89

90 // Set the loopback flag for UDP socket. If this flag is true, the host	90 // Set the loopback flag for UDP socket. If this flag is true, the host

91 // will receive packets sent to the joined group from itself.	91 // will receive packets sent to the joined group from itself.

92 // The default value of this option is true.	92 // The default value of this option is true.

93 // Should be called before Bind().	93 // Should be called before Bind().

94 // Returns a network error code.	94 // Returns a network error code.

95 virtual int SetMulticastLoopbackMode(bool loopback) = 0;	95 virtual int SetMulticastLoopbackMode(bool loopback) = 0;

	96

	97 // Set the Differentiated Services Code Point.
	Sergey Ulanov 2013/08/17 05:50:04 nit: This is a strange way to format comments. why nit: This is a strange way to format comments. why one sentence per line? I understand that comments above are the same, so it would be great to reformat them as well :-) hubbe 2013/08/21 18:51:36 Old habits die hard. :) I reformatted this one for Show quoted text On 2013/08/17 05:50:04, Sergey Ulanov wrote: > nit: This is a strange way to format comments. why one sentence per line? I > understand that comments above are the same, so it would be great to reformat > them as well :-) Old habits die hard. :) I reformatted this one for now.
	98 // May do nothing on some platforms.

	99 // Should be called before Bind().

	100 // Returns a network error code.

	101 virtual int SetToS(DiffServCodePoint dscp) = 0;
	Sergey Ulanov 2013/08/17 05:50:04 Maybe call it SetTos()? SetToS reads as "set to s" Maybe call it SetTos()? SetToS reads as "set to s" which makes no sense. Sergey Ulanov 2013/08/17 05:50:04 This seem like something that belongs to UDPServer This seem like something that belongs to UDPServerSocket, but not here. It's specific to datagram sockets that work over IP. hubbe 2013/08/21 18:51:36 Done. (Although, perhaps SetDSCP would be better.. Show quoted text On 2013/08/17 05:50:04, Sergey Ulanov wrote: > Maybe call it SetTos()? SetToS reads as "set to s" which makes no sense. Done. (Although, perhaps SetDSCP would be better...) hubbe 2013/08/21 18:51:36 I can't be sure, because this class doesn't docume Show quoted text On 2013/08/17 05:50:04, Sergey Ulanov wrote: > This seem like something that belongs to UDPServerSocket, but not here. It's > specific to datagram sockets that work over IP. I can't be sure, because this class doesn't document it's intent. But from what it looks like, DatagramServerSocket is simple an interface for UDPServerSocket to make it easy to mock out when testing. Thus, all methods in UDPServerSocket are overrides from this class. If DatagramServerSocket is meant to encapsulate datagrams other than UDP/IP, then I should probably move this function definition. (But in that case, we should probably move the multicast stuff too, since that is also an IP level feature, is it not?)
96 };	102 };

97	103

98 } // namespace net	104 } // namespace net

99	105

100 #endif // NET_UDP_DATAGRAM_SERVER_SOCKET_H_	106 #endif // NET_UDP_DATAGRAM_SERVER_SOCKET_H_

OLD	NEW