Video Capture Mojo (1.4b): Implement ability to use fake device instance

services/video_capture/video_capture_device_factory_impl.h

Index: services/video_capture/video_capture_device_factory_impl.h
diff --git a/services/video_capture/video_capture_device_factory_impl.h b/services/video_capture/video_capture_device_factory_impl.h
index b07f3169b9e29ba2ab39ea81a15bec2861f84e90..976fb72210b6192efe2199aa70ae372b3ab42e2b 100644
--- a/services/video_capture/video_capture_device_factory_impl.h
+++ b/services/video_capture/video_capture_device_factory_impl.h
@@ -7,6 +7,7 @@
 
 #include <vector>
 
+#include "mojo/public/cpp/bindings/binding.h"
 #include "services/video_capture/public/interfaces/video_capture_device_factory.mojom.h"
 #include "services/video_capture/video_capture_device_proxy_impl.h"
 
@@ -47,10 +48,16 @@ class VideoCaptureDeviceFactoryImpl : public mojom::VideoCaptureDeviceFactory {
     DeviceEntry& operator=(DeviceEntry&& other);
 
     mojom::VideoCaptureDeviceDescriptorPtr MakeDescriptorCopy() const;
+    bool DescriptorEquals(
+        const mojom::VideoCaptureDeviceDescriptorPtr& other) const;
+    bool is_bound() const;
+    void Bind(mojom::VideoCaptureDeviceProxyRequest request);
+    void Unbind();
 
    private:
     mojom::VideoCaptureDeviceDescriptorPtr descriptor_;
     std::unique_ptr<VideoCaptureDeviceProxyImpl> device_proxy_;
+    std::unique_ptr<mojo::Binding<mojom::VideoCaptureDeviceProxy>> binding_;

[Ken Rockot(use gerrit already), 2016/08/19 17:49:00]

I don't see any reason to use a unique_ptr here. Just use a mojo::Binding
directly?

[chfremer, 2016/08/19 18:11:19]

I tried that initially, but found that an inconvenient amount of complexity was
needed to implement the move operators, since mojo::Binding does not offer them.
Decided to fall back to using a unique_ptr<>. 

Should we consider adding move operators for mojo::Binding?

 
     DISALLOW_COPY_AND_ASSIGN(DeviceEntry);
   };