Video Capture Mojo (1.4b): Implement ability to use fake device instance

services/video_capture/video_capture_device_factory_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_IMPL_H_
 #define SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_IMPL_H_
 
 #include <vector>
 
+#include "mojo/public/cpp/bindings/binding.h"
 #include "services/video_capture/public/interfaces/video_capture_device_factory.mojom.h"
 #include "services/video_capture/video_capture_device_proxy_impl.h"
 
 namespace video_capture {
 
 class VideoCaptureDeviceFactoryImpl : public mojom::VideoCaptureDeviceFactory {
  public:
   VideoCaptureDeviceFactoryImpl();
   ~VideoCaptureDeviceFactoryImpl() override;
 
@@ skipping 20 matching lines @@
   // the number of capture devices is typically small.
   class DeviceEntry {
    public:
     DeviceEntry(mojom::VideoCaptureDeviceDescriptorPtr descriptor,
                 std::unique_ptr<VideoCaptureDeviceProxyImpl> bindable_target);
     ~DeviceEntry();
     DeviceEntry(DeviceEntry&& other);
     DeviceEntry& operator=(DeviceEntry&& other);
 
     mojom::VideoCaptureDeviceDescriptorPtr MakeDescriptorCopy() const;
+    bool DescriptorEquals(
+        const mojom::VideoCaptureDeviceDescriptorPtr& other) const;
+    bool is_bound() const;
+    void Bind(mojom::VideoCaptureDeviceProxyRequest request);
+    void Unbind();
 
    private:
     mojom::VideoCaptureDeviceDescriptorPtr descriptor_;
     std::unique_ptr<VideoCaptureDeviceProxyImpl> device_proxy_;
+    std::unique_ptr<mojo::Binding<mojom::VideoCaptureDeviceProxy>> binding_;

[Ken Rockot(use gerrit already), 2016/08/19 17:49:00]

I don't see any reason to use a unique_ptr here. Just use a mojo::Binding
directly?

[chfremer, 2016/08/19 18:11:19]

I tried that initially, but found that an inconvenient amount of complexity was
needed to implement the move operators, since mojo::Binding does not offer them.
Decided to fall back to using a unique_ptr<>. 

Should we consider adding move operators for mojo::Binding?

 
     DISALLOW_COPY_AND_ASSIGN(DeviceEntry);
   };
 
   std::vector<DeviceEntry> devices_;
 };
 
 }  // namespace video_capture
 
 #endif  // SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_IMPL_H_