components/invalidation/impl/invalidation_service_android.cc - Issue 2237943002: Remove now-unnecessary .obj() in Java method calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/invalidation_service_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context

Patch Set: Rebase *again* :( Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/instance_id/instance_id_android.cc ('k') | components/navigation_interception/intercept_navigation_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/impl/invalidation_service_android.cc

diff --git a/components/invalidation/impl/invalidation_service_android.cc b/components/invalidation/impl/invalidation_service_android.cc

index bc30b0fbad1929bdbe2d0e4ac154af224c69afb2..c909c421ec0fc8c597bf8eceb2a247600839726e 100644

--- a/components/invalidation/impl/invalidation_service_android.cc

+++ b/components/invalidation/impl/invalidation_service_android.cc

@@ -64,10 +64,8 @@ bool InvalidationServiceAndroid::UpdateRegisteredInvalidationIds(

}

Java_InvalidationService_setRegisteredObjectIds(

- env,

- java_ref_.obj(),

- base::android::ToJavaIntArray(env, sources).obj(),

- base::android::ToJavaArrayOfStrings(env, names).obj());

+ env, java_ref_, base::android::ToJavaIntArray(env, sources),

+ base::android::ToJavaArrayOfStrings(env, names));

logger_.OnUpdateIds(invalidator_registrar_.GetSanitizedHandlersIdsMap());

return true;

@@ -93,7 +91,7 @@ std::string InvalidationServiceAndroid::GetInvalidatorClientId() const {

// Ask the Java code to for the invalidator ID it's currently using.

base::android::ScopedJavaLocalRef<_jbyteArray*> id_bytes_java =

- Java_InvalidationService_getInvalidatorClientId(env, java_ref_.obj());

+ Java_InvalidationService_getInvalidatorClientId(env, java_ref_);

// Convert it into a more convenient format for C++.

std::vector<uint8_t> id_bytes;