Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2911)

Unified Diff: chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc
diff --git a/chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc b/chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc
index 27d79bae396676807292608508872d6ec3afeb0a..79cf77ed7ddfe36ce63d593f0f5604fdaa9002d4 100644
--- a/chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc
+++ b/chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc
@@ -61,32 +61,28 @@ AutofillSaveCardInfoBar::CreateRenderInfoBar(JNIEnv* env) {
base::android::ScopedJavaLocalRef<jobject> java_delegate =
Java_AutofillSaveCardInfoBar_create(
env, reinterpret_cast<intptr_t>(this), GetEnumeratedIconId(),
- java_bitmap.obj(),
+ java_bitmap, base::android::ConvertUTF16ToJavaString(
+ env, delegate->GetMessageText()),
+ base::android::ConvertUTF16ToJavaString(env, delegate->GetLinkText()),
base::android::ConvertUTF16ToJavaString(
- env, delegate->GetMessageText()).obj(),
+ env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_OK)),
base::android::ConvertUTF16ToJavaString(
- env, delegate->GetLinkText()).obj(),
- base::android::ConvertUTF16ToJavaString(
- env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_OK)).obj(),
- base::android::ConvertUTF16ToJavaString(
- env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_CANCEL)).obj());
+ env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_CANCEL)));
Java_AutofillSaveCardInfoBar_addDetail(
- env, java_delegate.obj(),
+ env, java_delegate,
ResourceMapper::MapFromChromiumId(delegate->issuer_icon_id()),
- base::android::ConvertUTF16ToJavaString(
- env, delegate->card_label()).obj(),
- base::android::ConvertUTF16ToJavaString(
- env, delegate->card_sub_label()).obj());
+ base::android::ConvertUTF16ToJavaString(env, delegate->card_label()),
+ base::android::ConvertUTF16ToJavaString(env, delegate->card_sub_label()));
for (const auto& line : delegate->legal_messages()) {
Java_AutofillSaveCardInfoBar_addLegalMessageLine(
- env, java_delegate.obj(),
- base::android::ConvertUTF16ToJavaString(env, line.text()).obj());
+ env, java_delegate,
+ base::android::ConvertUTF16ToJavaString(env, line.text()));
for (const auto& link : line.links()) {
Java_AutofillSaveCardInfoBar_addLinkToLastLegalMessageLine(
- env, java_delegate.obj(), link.range.start(), link.range.end(),
- base::android::ConvertUTF8ToJavaString(env, link.url.spec()).obj());
+ env, java_delegate, link.range.start(), link.range.end(),
+ base::android::ConvertUTF8ToJavaString(env, link.url.spec()));
}
}

Powered by Google App Engine
This is Rietveld 408576698