Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Side by Side Diff: components/gcm_driver/instance_id/instance_id_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/gcm_driver/instance_id/instance_id_android.h" 5 #include "components/gcm_driver/instance_id/instance_id_android.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 : InstanceID(app_id, gcm_driver) { 55 : InstanceID(app_id, gcm_driver) {
56 DCHECK(thread_checker_.CalledOnValidThread()); 56 DCHECK(thread_checker_.CalledOnValidThread());
57 57
58 DCHECK(!app_id.empty()) << "Empty app_id is not supported"; 58 DCHECK(!app_id.empty()) << "Empty app_id is not supported";
59 // The |app_id| is stored in GCM's category field by the desktop InstanceID 59 // The |app_id| is stored in GCM's category field by the desktop InstanceID
60 // implementation, but because the category is reserved for the app's package 60 // implementation, but because the category is reserved for the app's package
61 // name on Android the subtype field is used instead. 61 // name on Android the subtype field is used instead.
62 std::string subtype = app_id; 62 std::string subtype = app_id;
63 63
64 JNIEnv* env = AttachCurrentThread(); 64 JNIEnv* env = AttachCurrentThread();
65 java_ref_.Reset(Java_InstanceIDBridge_create( 65 java_ref_.Reset(
66 env, reinterpret_cast<intptr_t>(this), 66 Java_InstanceIDBridge_create(env, reinterpret_cast<intptr_t>(this),
67 base::android::GetApplicationContext(), 67 base::android::GetApplicationContext(),
68 ConvertUTF8ToJavaString(env, subtype).obj())); 68 ConvertUTF8ToJavaString(env, subtype)));
69 } 69 }
70 70
71 InstanceIDAndroid::~InstanceIDAndroid() { 71 InstanceIDAndroid::~InstanceIDAndroid() {
72 DCHECK(thread_checker_.CalledOnValidThread()); 72 DCHECK(thread_checker_.CalledOnValidThread());
73 73
74 JNIEnv* env = AttachCurrentThread(); 74 JNIEnv* env = AttachCurrentThread();
75 Java_InstanceIDBridge_destroy(env, java_ref_.obj()); 75 Java_InstanceIDBridge_destroy(env, java_ref_);
76 } 76 }
77 77
78 void InstanceIDAndroid::GetID(const GetIDCallback& callback) { 78 void InstanceIDAndroid::GetID(const GetIDCallback& callback) {
79 DCHECK(thread_checker_.CalledOnValidThread()); 79 DCHECK(thread_checker_.CalledOnValidThread());
80 80
81 int32_t request_id = get_id_callbacks_.Add(new GetIDCallback(callback)); 81 int32_t request_id = get_id_callbacks_.Add(new GetIDCallback(callback));
82 82
83 JNIEnv* env = AttachCurrentThread(); 83 JNIEnv* env = AttachCurrentThread();
84 Java_InstanceIDBridge_getId(env, java_ref_.obj(), request_id); 84 Java_InstanceIDBridge_getId(env, java_ref_, request_id);
85 } 85 }
86 86
87 void InstanceIDAndroid::GetCreationTime( 87 void InstanceIDAndroid::GetCreationTime(
88 const GetCreationTimeCallback& callback) { 88 const GetCreationTimeCallback& callback) {
89 DCHECK(thread_checker_.CalledOnValidThread()); 89 DCHECK(thread_checker_.CalledOnValidThread());
90 90
91 int32_t request_id = 91 int32_t request_id =
92 get_creation_time_callbacks_.Add(new GetCreationTimeCallback(callback)); 92 get_creation_time_callbacks_.Add(new GetCreationTimeCallback(callback));
93 93
94 JNIEnv* env = AttachCurrentThread(); 94 JNIEnv* env = AttachCurrentThread();
95 Java_InstanceIDBridge_getCreationTime(env, java_ref_.obj(), request_id); 95 Java_InstanceIDBridge_getCreationTime(env, java_ref_, request_id);
96 } 96 }
97 97
98 void InstanceIDAndroid::GetToken( 98 void InstanceIDAndroid::GetToken(
99 const std::string& authorized_entity, 99 const std::string& authorized_entity,
100 const std::string& scope, 100 const std::string& scope,
101 const std::map<std::string, std::string>& options, 101 const std::map<std::string, std::string>& options,
102 const GetTokenCallback& callback) { 102 const GetTokenCallback& callback) {
103 DCHECK(thread_checker_.CalledOnValidThread()); 103 DCHECK(thread_checker_.CalledOnValidThread());
104 104
105 int32_t request_id = get_token_callbacks_.Add(new GetTokenCallback(callback)); 105 int32_t request_id = get_token_callbacks_.Add(new GetTokenCallback(callback));
106 106
107 std::vector<std::string> options_strings; 107 std::vector<std::string> options_strings;
108 for (const auto& entry : options) { 108 for (const auto& entry : options) {
109 options_strings.push_back(entry.first); 109 options_strings.push_back(entry.first);
110 options_strings.push_back(entry.second); 110 options_strings.push_back(entry.second);
111 } 111 }
112 112
113 JNIEnv* env = AttachCurrentThread(); 113 JNIEnv* env = AttachCurrentThread();
114 Java_InstanceIDBridge_getToken( 114 Java_InstanceIDBridge_getToken(
115 env, java_ref_.obj(), request_id, 115 env, java_ref_, request_id,
116 ConvertUTF8ToJavaString(env, authorized_entity).obj(), 116 ConvertUTF8ToJavaString(env, authorized_entity),
117 ConvertUTF8ToJavaString(env, scope).obj(), 117 ConvertUTF8ToJavaString(env, scope),
118 base::android::ToJavaArrayOfStrings(env, options_strings).obj()); 118 base::android::ToJavaArrayOfStrings(env, options_strings));
119 } 119 }
120 120
121 void InstanceIDAndroid::DeleteTokenImpl(const std::string& authorized_entity, 121 void InstanceIDAndroid::DeleteTokenImpl(const std::string& authorized_entity,
122 const std::string& scope, 122 const std::string& scope,
123 const DeleteTokenCallback& callback) { 123 const DeleteTokenCallback& callback) {
124 DCHECK(thread_checker_.CalledOnValidThread()); 124 DCHECK(thread_checker_.CalledOnValidThread());
125 125
126 int32_t request_id = 126 int32_t request_id =
127 delete_token_callbacks_.Add(new DeleteTokenCallback(callback)); 127 delete_token_callbacks_.Add(new DeleteTokenCallback(callback));
128 128
129 JNIEnv* env = AttachCurrentThread(); 129 JNIEnv* env = AttachCurrentThread();
130 Java_InstanceIDBridge_deleteToken( 130 Java_InstanceIDBridge_deleteToken(
131 env, java_ref_.obj(), request_id, 131 env, java_ref_, request_id,
132 ConvertUTF8ToJavaString(env, authorized_entity).obj(), 132 ConvertUTF8ToJavaString(env, authorized_entity),
133 ConvertUTF8ToJavaString(env, scope).obj()); 133 ConvertUTF8ToJavaString(env, scope));
134 } 134 }
135 135
136 void InstanceIDAndroid::DeleteIDImpl(const DeleteIDCallback& callback) { 136 void InstanceIDAndroid::DeleteIDImpl(const DeleteIDCallback& callback) {
137 DCHECK(thread_checker_.CalledOnValidThread()); 137 DCHECK(thread_checker_.CalledOnValidThread());
138 138
139 int32_t request_id = delete_id_callbacks_.Add(new DeleteIDCallback(callback)); 139 int32_t request_id = delete_id_callbacks_.Add(new DeleteIDCallback(callback));
140 140
141 JNIEnv* env = AttachCurrentThread(); 141 JNIEnv* env = AttachCurrentThread();
142 Java_InstanceIDBridge_deleteInstanceID(env, java_ref_.obj(), request_id); 142 Java_InstanceIDBridge_deleteInstanceID(env, java_ref_, request_id);
143 } 143 }
144 144
145 void InstanceIDAndroid::DidGetID( 145 void InstanceIDAndroid::DidGetID(
146 JNIEnv* env, 146 JNIEnv* env,
147 const base::android::JavaParamRef<jobject>& obj, 147 const base::android::JavaParamRef<jobject>& obj,
148 jint request_id, 148 jint request_id,
149 const base::android::JavaParamRef<jstring>& jid) { 149 const base::android::JavaParamRef<jstring>& jid) {
150 DCHECK(thread_checker_.CalledOnValidThread()); 150 DCHECK(thread_checker_.CalledOnValidThread());
151 151
152 GetIDCallback* callback = get_id_callbacks_.Lookup(request_id); 152 GetIDCallback* callback = get_id_callbacks_.Lookup(request_id);
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 jboolean success) { 212 jboolean success) {
213 DCHECK(thread_checker_.CalledOnValidThread()); 213 DCHECK(thread_checker_.CalledOnValidThread());
214 214
215 DeleteIDCallback* callback = delete_id_callbacks_.Lookup(request_id); 215 DeleteIDCallback* callback = delete_id_callbacks_.Lookup(request_id);
216 DCHECK(callback); 216 DCHECK(callback);
217 callback->Run(success ? InstanceID::SUCCESS : InstanceID::UNKNOWN_ERROR); 217 callback->Run(success ? InstanceID::SUCCESS : InstanceID::UNKNOWN_ERROR);
218 delete_id_callbacks_.Remove(request_id); 218 delete_id_callbacks_.Remove(request_id);
219 } 219 }
220 220
221 } // namespace instance_id 221 } // namespace instance_id
OLDNEW
« no previous file with comments | « components/gcm_driver/gcm_driver_android.cc ('k') | components/invalidation/impl/invalidation_service_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698