Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: chrome/browser/password_manager/credential_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/credential_android.h" 5 #include "chrome/browser/password_manager/credential_android.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/grit/generated_resources.h" 9 #include "chrome/grit/generated_resources.h"
10 #include "jni/Credential_jni.h" 10 #include "jni/Credential_jni.h"
11 #include "ui/base/l10n/l10n_util.h" 11 #include "ui/base/l10n/l10n_util.h"
12 #include "url/origin.h" 12 #include "url/origin.h"
13 13
14 base::android::ScopedJavaLocalRef<jobject> CreateNativeCredential( 14 base::android::ScopedJavaLocalRef<jobject> CreateNativeCredential(
15 JNIEnv* env, 15 JNIEnv* env,
16 const autofill::PasswordForm& password_form, 16 const autofill::PasswordForm& password_form,
17 int position, 17 int position,
18 int type) { 18 int type) {
19 using base::android::ConvertUTF16ToJavaString; 19 using base::android::ConvertUTF16ToJavaString;
20 using base::android::ConvertUTF8ToJavaString; 20 using base::android::ConvertUTF8ToJavaString;
21 std::string federation = 21 std::string federation =
22 password_form.federation_origin.unique() 22 password_form.federation_origin.unique()
23 ? std::string() 23 ? std::string()
24 : l10n_util::GetStringFUTF8( 24 : l10n_util::GetStringFUTF8(
25 IDS_PASSWORDS_VIA_FEDERATION, 25 IDS_PASSWORDS_VIA_FEDERATION,
26 base::ASCIIToUTF16(password_form.federation_origin.host())); 26 base::ASCIIToUTF16(password_form.federation_origin.host()));
27 return Java_Credential_createCredential( 27 return Java_Credential_createCredential(
28 env, ConvertUTF16ToJavaString(env, password_form.username_value).obj(), 28 env, ConvertUTF16ToJavaString(env, password_form.username_value),
29 ConvertUTF16ToJavaString(env, password_form.display_name).obj(), 29 ConvertUTF16ToJavaString(env, password_form.display_name),
30 ConvertUTF8ToJavaString(env, federation).obj(), type, position); 30 ConvertUTF8ToJavaString(env, federation), type, position);
31 } 31 }
32 32
33 base::android::ScopedJavaLocalRef<jobjectArray> CreateNativeCredentialArray( 33 base::android::ScopedJavaLocalRef<jobjectArray> CreateNativeCredentialArray(
34 JNIEnv* env, 34 JNIEnv* env,
35 size_t size) { 35 size_t size) {
36 return Java_Credential_createCredentialArray(env, static_cast<int>(size)); 36 return Java_Credential_createCredentialArray(env, static_cast<int>(size));
37 } 37 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698