Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/contents/android/blimp_navigation_controller_impl_an droid.h" 5 #include "blimp/client/core/contents/android/blimp_navigation_controller_impl_an droid.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 28 matching lines...) Expand all
39 BlimpNavigationControllerImpl* blimp_navigation_controller_impl) 39 BlimpNavigationControllerImpl* blimp_navigation_controller_impl)
40 : blimp_navigation_controller_impl_(blimp_navigation_controller_impl) { 40 : blimp_navigation_controller_impl_(blimp_navigation_controller_impl) {
41 JNIEnv* env = base::android::AttachCurrentThread(); 41 JNIEnv* env = base::android::AttachCurrentThread();
42 java_obj_.Reset(env, Java_BlimpNavigationControllerImpl_create( 42 java_obj_.Reset(env, Java_BlimpNavigationControllerImpl_create(
43 env, reinterpret_cast<intptr_t>(this)) 43 env, reinterpret_cast<intptr_t>(this))
44 .obj()); 44 .obj());
45 } 45 }
46 46
47 BlimpNavigationControllerImplAndroid::~BlimpNavigationControllerImplAndroid() { 47 BlimpNavigationControllerImplAndroid::~BlimpNavigationControllerImplAndroid() {
48 Java_BlimpNavigationControllerImpl_clearNativePtr( 48 Java_BlimpNavigationControllerImpl_clearNativePtr(
49 base::android::AttachCurrentThread(), java_obj_.obj()); 49 base::android::AttachCurrentThread(), java_obj_);
50 } 50 }
51 51
52 void BlimpNavigationControllerImplAndroid::LoadURL( 52 void BlimpNavigationControllerImplAndroid::LoadURL(
53 JNIEnv* env, 53 JNIEnv* env,
54 jobject jobj, 54 jobject jobj,
55 const base::android::JavaParamRef<jstring>& jurl) { 55 const base::android::JavaParamRef<jstring>& jurl) {
56 GURL url = GURL(base::android::ConvertJavaStringToUTF8(env, jurl)); 56 GURL url = GURL(base::android::ConvertJavaStringToUTF8(env, jurl));
57 blimp_navigation_controller_impl_->LoadURL(url); 57 blimp_navigation_controller_impl_->LoadURL(url);
58 } 58 }
59 59
(...skipping 28 matching lines...) Expand all
88 } 88 }
89 89
90 void BlimpNavigationControllerImplAndroid::Reload( 90 void BlimpNavigationControllerImplAndroid::Reload(
91 JNIEnv* env, 91 JNIEnv* env,
92 const JavaParamRef<jobject>& obj) { 92 const JavaParamRef<jobject>& obj) {
93 blimp_navigation_controller_impl_->Reload(); 93 blimp_navigation_controller_impl_->Reload();
94 } 94 }
95 95
96 } // namespace client 96 } // namespace client
97 } // namespace blimp 97 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698