Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2237813002: [turbofan] Cleanup for Float64Max and Float64Min. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cleanup for Float64Max and Float64Min. This CL removes the optional operator flag of Float64Max and Float64Min. Additionally it renames the instruction codes on x64 and ia32 because the old instructions codes (e.g. SSEFloat64Max) do not match the generated code anymore. R=bmeurer@chromium.org Committed: https://crrev.com/4150b5c68f0ff2b29202947c26a272b0713a0904 Cr-Commit-Position: refs/heads/master@{#38674}

Patch Set 1 #

Patch Set 2 : Undo the renaming. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -32 lines) Patch
M src/compiler/machine-operator.h View 1 chunk +27 lines, -32 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
ahaas
4 years, 4 months ago (2016-08-11 11:15:52 UTC) #1
ahaas
On 2016/08/11 at 11:15:52, ahaas wrote: > PTAL
4 years, 4 months ago (2016-08-16 17:33:52 UTC) #7
Benedikt Meurer
Hm, it's still implemented via SSE instructions. Not sure what the naming implies tho.
4 years, 4 months ago (2016-08-16 17:38:30 UTC) #8
ahaas
On 2016/08/16 at 17:38:30, bmeurer wrote: > Hm, it's still implemented via SSE instructions. Not ...
4 years, 4 months ago (2016-08-17 08:09:22 UTC) #11
titzer
lgtm
4 years, 4 months ago (2016-08-17 08:11:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237813002/20001
4 years, 4 months ago (2016-08-17 08:32:19 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 08:34:00 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 08:34:32 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4150b5c68f0ff2b29202947c26a272b0713a0904
Cr-Commit-Position: refs/heads/master@{#38674}

Powered by Google App Engine
This is Rietveld 408576698