Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/compiler/machine-operator.h

Issue 2237813002: [turbofan] Cleanup for Float64Max and Float64Min. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Undo the renaming. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/machine-operator.h
diff --git a/src/compiler/machine-operator.h b/src/compiler/machine-operator.h
index e1a1eb85849a9a697663d17bd7c8c872240231c8..92c698676839e3be3eabac6247330507ffe4ec39 100644
--- a/src/compiler/machine-operator.h
+++ b/src/compiler/machine-operator.h
@@ -104,40 +104,35 @@ class MachineOperatorBuilder final : public ZoneObject {
// for operations that are unsupported by some back-ends.
enum Flag : unsigned {
kNoFlags = 0u,
- // Note that Float*Max behaves like `(b < a) ? a : b`, not like Math.max().
- // Note that Float*Min behaves like `(a < b) ? a : b`, not like Math.min().
kFloat32Max = 1u << 0,
kFloat32Min = 1u << 1,
- kFloat64Max = 1u << 2,
- kFloat64Min = 1u << 3,
- kFloat32RoundDown = 1u << 4,
- kFloat64RoundDown = 1u << 5,
- kFloat32RoundUp = 1u << 6,
- kFloat64RoundUp = 1u << 7,
- kFloat32RoundTruncate = 1u << 8,
- kFloat64RoundTruncate = 1u << 9,
- kFloat32RoundTiesEven = 1u << 10,
- kFloat64RoundTiesEven = 1u << 11,
- kFloat64RoundTiesAway = 1u << 12,
- kInt32DivIsSafe = 1u << 13,
- kUint32DivIsSafe = 1u << 14,
- kWord32ShiftIsSafe = 1u << 15,
- kWord32Ctz = 1u << 16,
- kWord64Ctz = 1u << 17,
- kWord32Popcnt = 1u << 18,
- kWord64Popcnt = 1u << 19,
- kWord32ReverseBits = 1u << 20,
- kWord64ReverseBits = 1u << 21,
- kWord32ReverseBytes = 1u << 22,
- kWord64ReverseBytes = 1u << 23,
- kAllOptionalOps = kFloat32Max | kFloat32Min | kFloat64Max | kFloat64Min |
- kFloat32RoundDown | kFloat64RoundDown | kFloat32RoundUp |
- kFloat64RoundUp | kFloat32RoundTruncate |
- kFloat64RoundTruncate | kFloat64RoundTiesAway |
- kFloat32RoundTiesEven | kFloat64RoundTiesEven |
- kWord32Ctz | kWord64Ctz | kWord32Popcnt | kWord64Popcnt |
- kWord32ReverseBits | kWord64ReverseBits |
- kWord32ReverseBytes | kWord64ReverseBytes
+ kFloat32RoundDown = 1u << 2,
+ kFloat64RoundDown = 1u << 3,
+ kFloat32RoundUp = 1u << 4,
+ kFloat64RoundUp = 1u << 5,
+ kFloat32RoundTruncate = 1u << 6,
+ kFloat64RoundTruncate = 1u << 7,
+ kFloat32RoundTiesEven = 1u << 8,
+ kFloat64RoundTiesEven = 1u << 9,
+ kFloat64RoundTiesAway = 1u << 10,
+ kInt32DivIsSafe = 1u << 11,
+ kUint32DivIsSafe = 1u << 12,
+ kWord32ShiftIsSafe = 1u << 13,
+ kWord32Ctz = 1u << 14,
+ kWord64Ctz = 1u << 15,
+ kWord32Popcnt = 1u << 16,
+ kWord64Popcnt = 1u << 17,
+ kWord32ReverseBits = 1u << 18,
+ kWord64ReverseBits = 1u << 19,
+ kWord32ReverseBytes = 1u << 20,
+ kWord64ReverseBytes = 1u << 21,
+ kAllOptionalOps =
+ kFloat32Max | kFloat32Min | kFloat32RoundDown | kFloat64RoundDown |
+ kFloat32RoundUp | kFloat64RoundUp | kFloat32RoundTruncate |
+ kFloat64RoundTruncate | kFloat64RoundTiesAway | kFloat32RoundTiesEven |
+ kFloat64RoundTiesEven | kWord32Ctz | kWord64Ctz | kWord32Popcnt |
+ kWord64Popcnt | kWord32ReverseBits | kWord64ReverseBits |
+ kWord32ReverseBytes | kWord64ReverseBytes
};
typedef base::Flags<Flag, unsigned> Flags;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698