Disable flaky assert in ~SyncPointManager on CrOS.

Disable flaky assert in ~SyncPointManager on CrOS.

BUG=630625
TBR=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

[esprehn, 2016-08-10 21:10:45]

Description was changed from

==========
Disable flaky assert in ~SyncPointManager on CrOS.

BUG=630625
==========

to

==========
Disable flaky assert in ~SyncPointManager on CrOS.

BUG=630625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[esprehn, 2016-08-10 21:11:39]

Description was changed from

==========
Disable flaky assert in ~SyncPointManager on CrOS.

BUG=630625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Disable flaky assert in ~SyncPointManager on CrOS.

BUG=630625
TBR=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[esprehn, 2016-08-10 21:11:40]

esprehn@chromium.org changed reviewers:
+ reveman@chromium.org

[esprehn, 2016-08-10 21:11:42]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:12:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-08-10 21:16:41]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-08-10 21:16:54]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-08-10 21:16:54]

NAK. please disable the tests

[esprehn, 2016-08-10 21:17:21]

On 2016/08/10 at 21:16:54, piman wrote:
> NAK. please disable the tests

No, this is flaking tons of tests all over the codebase for 30 days now.

[esprehn, 2016-08-10 21:17:28]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2016-08-10 21:18:00]

On 2016/08/10 at 21:17:21, esprehn wrote:
> On 2016/08/10 at 21:16:54, piman wrote:
> > NAK. please disable the tests
> 
> No, this is flaking tons of tests all over the codebase for 30 days now.

DisplayTest.CreatePopupShellSurface
DisplayTest.CreateSubSurface
DisplayTest.CreateSurface
GamepadTest.OnButton
PointerTest.OnPointerEnter
KeyboardTest.OnKeyboardKey
BufferTest.IsLost
BufferTest.ReleaseCallback
GamepadTest.OnWindowFocused
KeyboardTest.OnKeyboardModifiers
DisplayTest.CreateShellSurface
PointerTest.OnPointerMotion
KeyboardTest.OnKeyboardLeave
PointerTest.OnPointerLeave
DisplayTest.CreateSharedMemory
DisplayTest.CreateRemoteShellSurface
GamepadTest.OnAxis
GamepadTest.OnStateChange
PointerTest.SetCursor
KeyboardTest.OnKeyboardEnter

If you think this ASSERT is important you need to fix it, otherwise I'm
disabling it.

[commit-bot: I haz the power, 2016-08-10 21:18:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-08-10 21:19:06]

On 2016/08/10 21:18:00, esprehn wrote:
> On 2016/08/10 at 21:17:21, esprehn wrote:
> > On 2016/08/10 at 21:16:54, piman wrote:
> > > NAK. please disable the tests
> > 
> > No, this is flaking tons of tests all over the codebase for 30 days now.
> 
> DisplayTest.CreatePopupShellSurface
> DisplayTest.CreateSubSurface
> DisplayTest.CreateSurface
> GamepadTest.OnButton
> PointerTest.OnPointerEnter
> KeyboardTest.OnKeyboardKey
> BufferTest.IsLost
> BufferTest.ReleaseCallback
> GamepadTest.OnWindowFocused
> KeyboardTest.OnKeyboardModifiers
> DisplayTest.CreateShellSurface
> PointerTest.OnPointerMotion
> KeyboardTest.OnKeyboardLeave
> PointerTest.OnPointerLeave
> DisplayTest.CreateSharedMemory
> DisplayTest.CreateRemoteShellSurface
> GamepadTest.OnAxis
> GamepadTest.OnStateChange
> PointerTest.SetCursor
> KeyboardTest.OnKeyboardEnter
> 
> If you think this ASSERT is important you need to fix it, otherwise I'm
> disabling it.

If the tests don't clean up correctly, they need to be disabled.

[piman, 2016-08-10 21:19:11]

The CQ bit was unchecked by piman@chromium.org

[esprehn, 2016-08-10 21:19:51]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:20:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-10 21:21:06]

On 2016/08/10 at 21:19:06, piman wrote:
> On 2016/08/10 21:18:00, esprehn wrote:
> > On 2016/08/10 at 21:17:21, esprehn wrote:
> > > On 2016/08/10 at 21:16:54, piman wrote:
> > > > NAK. please disable the tests
> > > 
> > > No, this is flaking tons of tests all over the codebase for 30 days now.
> > 
> > DisplayTest.CreatePopupShellSurface
> > DisplayTest.CreateSubSurface
> > DisplayTest.CreateSurface
> > GamepadTest.OnButton
> > PointerTest.OnPointerEnter
> > KeyboardTest.OnKeyboardKey
> > BufferTest.IsLost
> > BufferTest.ReleaseCallback
> > GamepadTest.OnWindowFocused
> > KeyboardTest.OnKeyboardModifiers
> > DisplayTest.CreateShellSurface
> > PointerTest.OnPointerMotion
> > KeyboardTest.OnKeyboardLeave
> > PointerTest.OnPointerLeave
> > DisplayTest.CreateSharedMemory
> > DisplayTest.CreateRemoteShellSurface
> > GamepadTest.OnAxis
> > GamepadTest.OnStateChange
> > PointerTest.SetCursor
> > KeyboardTest.OnKeyboardEnter
> > 
> > If you think this ASSERT is important you need to fix it, otherwise I'm
> > disabling it.
> 
> If the tests don't clean up correctly, they need to be disabled.

It's been assigned to the GPU team for 30 days now. I'm not going to play
whack-a-mole with the 5+ test suites this is flaking.

[piman, 2016-08-10 21:27:16]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-08-10 21:41:26]

On 2016/08/10 21:21:06, esprehn wrote:
> On 2016/08/10 at 21:19:06, piman wrote:
> > On 2016/08/10 21:18:00, esprehn wrote:
> > > On 2016/08/10 at 21:17:21, esprehn wrote:
> > > > On 2016/08/10 at 21:16:54, piman wrote:
> > > > > NAK. please disable the tests
> > > > 
> > > > No, this is flaking tons of tests all over the codebase for 30 days now.
> > > 
> > > DisplayTest.CreatePopupShellSurface
> > > DisplayTest.CreateSubSurface
> > > DisplayTest.CreateSurface
> > > GamepadTest.OnButton
> > > PointerTest.OnPointerEnter
> > > KeyboardTest.OnKeyboardKey
> > > BufferTest.IsLost
> > > BufferTest.ReleaseCallback
> > > GamepadTest.OnWindowFocused
> > > KeyboardTest.OnKeyboardModifiers
> > > DisplayTest.CreateShellSurface
> > > PointerTest.OnPointerMotion
> > > KeyboardTest.OnKeyboardLeave
> > > PointerTest.OnPointerLeave
> > > DisplayTest.CreateSharedMemory
> > > DisplayTest.CreateRemoteShellSurface
> > > GamepadTest.OnAxis
> > > GamepadTest.OnStateChange
> > > PointerTest.SetCursor
> > > KeyboardTest.OnKeyboardEnter
> > > 
> > > If you think this ASSERT is important you need to fix it, otherwise I'm
> > > disabling it.
> > 
> > If the tests don't clean up correctly, they need to be disabled.
> 
> It's been assigned to the GPU team for 30 days now. I'm not going to play
> whack-a-mole with the 5+ test suites this is flaking.

https://codereview.chromium.org/2235043002/ disables the tests.