Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2094)

Unified Diff: gpu/command_buffer/service/sync_point_manager.cc

Issue 2237653002: Disable flaky assert in ~SyncPointManager on CrOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/sync_point_manager.cc
diff --git a/gpu/command_buffer/service/sync_point_manager.cc b/gpu/command_buffer/service/sync_point_manager.cc
index 04a92e015b6e3264591115700e2819a5a6cce5c3..be147be427505fcc8987745108cd76288b6e8b3a 100644
--- a/gpu/command_buffer/service/sync_point_manager.cc
+++ b/gpu/command_buffer/service/sync_point_manager.cc
@@ -389,9 +389,12 @@ SyncPointManager::SyncPointManager(bool allow_threaded_wait) {
}
SyncPointManager::~SyncPointManager() {
+// TODO(reveman): Figure out why this flakes on CrOS: http://crbug.com/630625
+#if !defined(OS_CHROMEOS)
for (const ClientMap& client_map : client_maps_) {
DCHECK(client_map.empty());
}
+#endif
}
std::unique_ptr<SyncPointClient> SyncPointManager::CreateSyncPointClient(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698