Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: components/cronet/android/cronet_url_request_context_adapter.cc

Issue 2237603002: Cronet/QUIC - Added histograms to measure the time spent to seriliaze (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/cronet_url_request_context_adapter.cc
diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc
index b189fc4050c66ad5cb45d67533ba1a5497964dbd..51f65be928beabf9fb597b456f0188c507a6857a 100644
--- a/components/cronet/android/cronet_url_request_context_adapter.cc
+++ b/components/cronet/android/cronet_url_request_context_adapter.cc
@@ -25,6 +25,7 @@
#include "base/memory/ptr_util.h"
#include "base/memory/scoped_vector.h"
#include "base/message_loop/message_loop.h"
+#include "base/metrics/histogram_macros.h"
#include "base/metrics/statistics_recorder.h"
#include "base/single_thread_task_runner.h"
#include "base/time/time.h"
@@ -669,6 +670,7 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(
// If there is a cert_verifier, then populate its cache with
// |cert_verifier_data|.
if (!config->cert_verifier_data.empty() && context_->cert_verifier()) {
+ base::TimeTicks start_time(base::TimeTicks::Now());
std::string data;
cronet_pb::CertVerificationCache cert_verification_cache;
if (base::Base64Decode(config->cert_verifier_data, &data) &&
@@ -677,6 +679,8 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(
reinterpret_cast<net::CachingCertVerifier*>(
context_->cert_verifier()));
}
+ UMA_HISTOGRAM_TIMES("Net.Cronet.CertVerifierCache.DeserializeTime",
+ base::TimeTicks::Now() - start_time);
}
// Iterate through PKP configuration for every host.
@@ -803,12 +807,15 @@ void CronetURLRequestContextAdapter::GetCertVerifierDataOnNetworkThread() {
DCHECK(GetNetworkTaskRunner()->BelongsToCurrentThread());
std::string encoded_data;
if (is_context_initialized_ && context_->cert_verifier()) {
+ base::TimeTicks start_time(base::TimeTicks::Now());
std::string data;
cronet_pb::CertVerificationCache cert_cache =
SerializeCertVerifierCache(*reinterpret_cast<net::CachingCertVerifier*>(
context_->cert_verifier()));
cert_cache.SerializeToString(&data);
base::Base64Encode(data, &encoded_data);
+ UMA_HISTOGRAM_TIMES("Net.Cronet.CertVerifierCache.SerializeTime",
rkaplow 2016/08/11 17:14:23 you can simplify this using a SCOPED_UMA_HISTOGRAM
ramant (doing other things) 2016/08/11 17:21:15 Done.
+ base::TimeTicks::Now() - start_time);
}
JNIEnv* env = base::android::AttachCurrentThread();
Java_CronetUrlRequestContext_onGetCertVerifierData(
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698