Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2237553003:
(Reland) Added tombstones in instrumentation tests results. (Closed)
|
Created:
4 years, 4 months ago by BigBossZhiling Modified:
4 years, 4 months ago CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded tombstones in instrumentation tests results.
If an instrumentation test crashes, tombstones were not captured.
In this cl, tombstones are captured and becomes part of the result.
This is a reland of a previous cl, http://crrev.com/2201833002#ps200001.
The reason for reverting the previous cl is that:
it breaks the stack_tool_for_tombstones step for many bots in
https://build.chromium.org/p/chromium.android.
In this reland, the edge case where there is no tombstone is fixed.
BUG=631213
Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8
Cr-Commit-Position: refs/heads/master@{#410929}
patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001)
Committed: https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130
Cr-Commit-Position: refs/heads/master@{#412089}
Patch Set 1 #Patch Set 2 : fixed the error when tombstones is null #Patch Set 3 : rebase #
Messages
Total messages: 31 (18 generated)
hzl@google.com changed reviewers: + jbudorick@chromium.org
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
hzl@google.com changed reviewers: + mikecase@chromium.org
If this is relanding an old CL, I would link to the old CL and why you had to revert. And maybe add change the commit message to.. (Reland) Add tombstones in instrumentation test results.
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. The reason for reverting is: This breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android, like this: W 0.547s Main No tombstones. Traceback (most recent call last): File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 304, in <module> sys.exit(main()) File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 300, in main W 0.547s Main No tombstones to resolve. for line in resolved_tombstones: TypeError: 'NoneType' object is not iterable BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. The reason for reverting is: This breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android, like this: W 0.547s Main No tombstones. Traceback (most recent call last): File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 304, in <module> sys.exit(main()) File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 300, in main W 0.547s Main No tombstones to resolve. for line in resolved_tombstones: TypeError: 'NoneType' object is not iterable BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. The reason for reverting is: This breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. More details in this link: http://crrev.com/2201833002#ps200001 BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
lgtm, but please clean up the issue description before landing.
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. The reason for reverting is: This breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. More details in this link: http://crrev.com/2201833002#ps200001 BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
The CQ bit was checked by hzl@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by hzl@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hzl@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/2237553003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) ========== to ========== Added tombstones in instrumentation tests results. If an instrumentation test crashes, tombstones were not captured. In this cl, tombstones are captured and becomes part of the result. This is a reland of a previous cl, http://crrev.com/2201833002#ps200001. The reason for reverting the previous cl is that: it breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android. In this reland, the edge case where there is no tombstone is fixed. BUG=631213 Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 Cr-Commit-Position: refs/heads/master@{#410929} patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001) Committed: https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130 Cr-Commit-Position: refs/heads/master@{#412089} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130 Cr-Commit-Position: refs/heads/master@{#412089} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
