Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2237553003: (Reland) Added tombstones in instrumentation tests results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/pylib/instrumentation/test_result.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import os 6 import os
7 import posixpath 7 import posixpath
8 import re 8 import re
9 import time 9 import time
10 10
11 from devil.android import device_errors 11 from devil.android import device_errors
12 from devil.android import flag_changer 12 from devil.android import flag_changer
13 from devil.utils import reraiser_thread 13 from devil.utils import reraiser_thread
14 from pylib import valgrind_tools 14 from pylib import valgrind_tools
15 from pylib.base import base_test_result 15 from pylib.base import base_test_result
16 from pylib.local.device import local_device_environment 16 from pylib.local.device import local_device_environment
17 from pylib.local.device import local_device_test_run 17 from pylib.local.device import local_device_test_run
18 18 import tombstones
19 19
20 TIMEOUT_ANNOTATIONS = [ 20 TIMEOUT_ANNOTATIONS = [
21 ('Manual', 10 * 60 * 60), 21 ('Manual', 10 * 60 * 60),
22 ('IntegrationTest', 30 * 60), 22 ('IntegrationTest', 30 * 60),
23 ('External', 10 * 60), 23 ('External', 10 * 60),
24 ('EnormousTest', 10 * 60), 24 ('EnormousTest', 10 * 60),
25 ('LargeTest', 5 * 60), 25 ('LargeTest', 5 * 60),
26 ('MediumTest', 3 * 60), 26 ('MediumTest', 3 * 60),
27 ('SmallTest', 1 * 60), 27 ('SmallTest', 1 * 60),
28 ] 28 ]
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 136
137 valgrind_tools.SetChromeTimeoutScale( 137 valgrind_tools.SetChromeTimeoutScale(
138 dev, self._test_instance.timeout_scale) 138 dev, self._test_instance.timeout_scale)
139 139
140 steps = (install_apk, push_test_data, create_flag_changer) 140 steps = (install_apk, push_test_data, create_flag_changer)
141 if self._env.concurrent_adb: 141 if self._env.concurrent_adb:
142 reraiser_thread.RunAsync(steps) 142 reraiser_thread.RunAsync(steps)
143 else: 143 else:
144 for step in steps: 144 for step in steps:
145 step() 145 step()
146 if self._test_instance.store_tombstones:
147 tombstones.ClearAllTombstones(dev)
146 148
147 self._env.parallel_devices.pMap( 149 self._env.parallel_devices.pMap(
148 individual_device_set_up, 150 individual_device_set_up,
149 self._test_instance.GetDataDependencies()) 151 self._test_instance.GetDataDependencies())
150 152
151 def TearDown(self): 153 def TearDown(self):
152 @local_device_environment.handle_shard_failures_with( 154 @local_device_environment.handle_shard_failures_with(
153 self._env.BlacklistDevice) 155 self._env.BlacklistDevice)
154 def individual_device_tear_down(dev): 156 def individual_device_tear_down(dev):
155 if str(dev) in self._flag_changers: 157 if str(dev) in self._flag_changers:
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 324
323 else: 325 else:
324 logging.debug('raw output from %s:', test_display_name) 326 logging.debug('raw output from %s:', test_display_name)
325 for l in output: 327 for l in output:
326 logging.debug(' %s', l) 328 logging.debug(' %s', l)
327 if self._test_instance.coverage_directory: 329 if self._test_instance.coverage_directory:
328 device.PullFile(coverage_directory, 330 device.PullFile(coverage_directory,
329 self._test_instance.coverage_directory) 331 self._test_instance.coverage_directory)
330 device.RunShellCommand('rm -f %s' % os.path.join(coverage_directory, 332 device.RunShellCommand('rm -f %s' % os.path.join(coverage_directory,
331 '*')) 333 '*'))
334 if self._test_instance.store_tombstones:
335 for result in results:
336 if result.GetType() == base_test_result.ResultType.CRASH:
337 resolved_tombstones = tombstones.ResolveTombstones(
338 device,
339 resolve_all_tombstones=True,
340 include_stack_symbols=False,
341 wipe_tombstones=True)
342 result.SetTombstones('\n'.join(resolved_tombstones))
332 return results 343 return results
333 344
334 #override 345 #override
335 def _ShouldRetry(self, test): 346 def _ShouldRetry(self, test):
336 if 'RetryOnFailure' in test.get('annotations', {}): 347 if 'RetryOnFailure' in test.get('annotations', {}):
337 return True 348 return True
338 349
339 # TODO(jbudorick): Remove this log message and switch the return value to 350 # TODO(jbudorick): Remove this log message and switch the return value to
340 # False after tests have been annotated with @RetryOnFailure. 351 # False after tests have been annotated with @RetryOnFailure.
341 # See crbug.com/619055 for more details. 352 # See crbug.com/619055 for more details.
(...skipping 19 matching lines...) Expand all
361 timeout = v 372 timeout = v
362 break 373 break
363 else: 374 else:
364 logging.warning('Using default 1 minute timeout for %s', test_name) 375 logging.warning('Using default 1 minute timeout for %s', test_name)
365 timeout = 60 376 timeout = 60
366 377
367 timeout *= cls._GetTimeoutScaleFromAnnotations(annotations) 378 timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)
368 379
369 return timeout 380 return timeout
370 381
OLDNEW
« no previous file with comments | « build/android/pylib/instrumentation/test_result.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698