Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2237473003: [layoutng] Add helper functions to compute lengths (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Add helper functions to compute lengths R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org BUG=635619 Committed: https://crrev.com/62cd277117e6f8ec53e31b1be58290a6f7ab42ef Cr-Commit-Position: refs/heads/master@{#411148}

Patch Set 1 #

Patch Set 2 : Make it compile, and put inline functions before block #

Patch Set 3 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -4 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 2 chunks +5 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 2 1 chunk +84 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
cbiesinger
4 years, 4 months ago (2016-08-10 19:33:15 UTC) #1
eae
LGTM
4 years, 4 months ago (2016-08-10 19:34:43 UTC) #4
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-10 19:43:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237473003/20001
4 years, 4 months ago (2016-08-10 19:45:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237473003/40001
4 years, 4 months ago (2016-08-10 19:49:36 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 21:12:24 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 21:15:30 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/62cd277117e6f8ec53e31b1be58290a6f7ab42ef
Cr-Commit-Position: refs/heads/master@{#411148}

Powered by Google App Engine
This is Rietveld 408576698