Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2231153003: [layoutng] Make the layout algorithm actually compute and store positions and sizes (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@stuff
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Make the layout algorithm actually compute and store positions and sizes R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org BUG=635619 NOTRY=true Committed: https://crrev.com/491d8b316be0a2c2719d590310cd06ae754cc0f8 Cr-Commit-Position: refs/heads/master@{#411175}

Patch Set 1 #

Patch Set 2 : Add children to fragment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 1 chunk +13 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
cbiesinger
4 years, 4 months ago (2016-08-10 20:51:05 UTC) #1
eae
OK, as discussed. LGTM
4 years, 4 months ago (2016-08-10 20:58:15 UTC) #2
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-10 20:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231153003/20001
4 years, 4 months ago (2016-08-10 21:24:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231153003/20001
4 years, 4 months ago (2016-08-10 23:05:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 23:11:28 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 23:14:25 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/491d8b316be0a2c2719d590310cd06ae754cc0f8
Cr-Commit-Position: refs/heads/master@{#411175}

Powered by Google App Engine
This is Rietveld 408576698