Add ToSmi and Goto operations to FastAccessorAssembler.

Add ToSmi and Goto operations to FastAccessorAssembler.

BUG=chromium:508898
Committed: https://crrev.com/f4e92fe13e512b0f190db82fed8e1b0da2314cea
Cr-Commit-Position: refs/heads/master@{#38745}

[Alfonso, 2016-08-10 12:38:33]

Description was changed from

==========
Add ToSmi and Goto operations to FastAccessorAssembler.

BUG=chromium:508898
==========

to

==========
Add ToSmi and Goto operations to FastAccessorAssembler.

BUG=chromium:508898
==========

[Alfonso, 2016-08-10 12:38:34]

peterssen@google.com changed reviewers:
+ vogelheim@chromium.org

[Alfonso, 2016-08-10 12:38:49]

PTAL.

[vogelheim, 2016-08-12 08:08:14]

lgtm

https://codereview.chromium.org/2237443002/diff/1/src/fast-accessor-assembler.h
File src/fast-accessor-assembler.h (right):

https://codereview.chromium.org/2237443002/diff/1/src/fast-accessor-assembler...
src/fast-accessor-assembler.h:69: // Converts an integer to JS-compatible Smi
representation.
Maybe: "Converts a machine integer to a SMI."

Within V8, SMI is an established term, so the attempt of explaining it as
"JS-compatiable Smi representation" would probably be more confusing than
clarifying.

Since V8 doesn't normally deal with actual integers, we might add an adjective
to describe an actual machine integer, though, if we insist on distinguishing
those two representations.

[Alfonso, 2016-08-12 08:33:37]

The CQ bit was checked by peterssen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 08:33:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 08:53:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 08:53:37]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[Alfonso, 2016-08-12 16:06:08]

The CQ bit was checked by peterssen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 16:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 16:18:28]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Alfonso, 2016-08-18 10:05:41]

The CQ bit was checked by peterssen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 10:05:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 10:18:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 10:18:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Alfonso, 2016-08-19 09:05:18]

Patchset #3 (id:40001) has been deleted

[Alfonso, 2016-08-19 09:05:42]

The CQ bit was checked by peterssen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 09:05:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 09:28:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 09:28:40]

Dry run: This issue passed the CQ dry run.

[Alfonso, 2016-08-19 09:33:22]

The CQ bit was checked by peterssen@google.com

[Alfonso, 2016-08-19 09:33:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2237443002/#ps60001
(title: "Fix 32-bit SMI overflow in test")

[commit-bot: I haz the power, 2016-08-19 09:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 09:35:11]

Description was changed from

==========
Add ToSmi and Goto operations to FastAccessorAssembler.

BUG=chromium:508898
==========

to

==========
Add ToSmi and Goto operations to FastAccessorAssembler.

BUG=chromium:508898
==========

[commit-bot: I haz the power, 2016-08-19 09:35:12]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-19 09:35:20]

Description was changed from

==========
Add ToSmi and Goto operations to FastAccessorAssembler.

BUG=chromium:508898
==========

to

==========
Add ToSmi and Goto operations to FastAccessorAssembler.

BUG=chromium:508898

Committed: https://crrev.com/f4e92fe13e512b0f190db82fed8e1b0da2314cea
Cr-Commit-Position: refs/heads/master@{#38745}
==========

[commit-bot: I haz the power, 2016-08-19 09:35:21]

Patchset 3 (id:??) landed as
https://crrev.com/f4e92fe13e512b0f190db82fed8e1b0da2314cea
Cr-Commit-Position: refs/heads/master@{#38745}