Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: src/fast-accessor-assembler.cc

Issue 2237443002: Add ToSmi and Goto operations to FastAccessorAssembler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix 32-bit SMI overflow in test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/fast-accessor-assembler.h ('k') | test/cctest/test-api-fast-accessor-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/fast-accessor-assembler.cc
diff --git a/src/fast-accessor-assembler.cc b/src/fast-accessor-assembler.cc
index 6d46ae09384ed00cade6cce77ab935dc5fb3e7ff..ebaab9a529de17f8d1a479e92cb97a2dae9913c0 100644
--- a/src/fast-accessor-assembler.cc
+++ b/src/fast-accessor-assembler.cc
@@ -108,6 +108,11 @@ FastAccessorAssembler::ValueId FastAccessorAssembler::LoadObject(ValueId value,
0, MachineType::AnyTagged()));
}
+FastAccessorAssembler::ValueId FastAccessorAssembler::ToSmi(ValueId value) {
+ CHECK_EQ(kBuilding, state_);
+ return FromRaw(assembler_->SmiTag(FromId(value)));
+}
+
void FastAccessorAssembler::ReturnValue(ValueId value) {
CHECK_EQ(kBuilding, state_);
assembler_->Return(FromId(value));
@@ -149,6 +154,11 @@ void FastAccessorAssembler::SetLabel(LabelId label_id) {
assembler_->Bind(FromId(label_id));
}
+void FastAccessorAssembler::Goto(LabelId label_id) {
+ CHECK_EQ(kBuilding, state_);
+ assembler_->Goto(FromId(label_id));
+}
+
void FastAccessorAssembler::CheckNotZeroOrJump(ValueId value_id,
LabelId label_id) {
CHECK_EQ(kBuilding, state_);
« no previous file with comments | « src/fast-accessor-assembler.h ('k') | test/cctest/test-api-fast-accessor-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698