Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2237433004: Adds DevTools commands for forced viewport override. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Dmitry's comments + sync. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index b324f6cbf587cf5753c8568c4c7c340cb938b8d2..46ac8983fcbaa927145d4e364412bc2341a08973 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -302,7 +302,12 @@ public:
void setBackgroundColorOverride(WebColor);
void setZoomFactorOverride(float);
void setCompositorDeviceScaleFactorOverride(float);
- void setRootLayerTransform(const WebSize& offset, float scale);
+ void setRootLayerTransform(const TransformationMatrix&);
+ TransformationMatrix getRootLayerTransformForTesting() const;
+
+ // Returns the original device scale factor when overridden by DevTools, or
+ // deviceScaleFactor() otherwise.
+ float compositorDeviceScaleFactor() const;
Color baseBackgroundColor() const { return m_baseBackgroundColor; }
@@ -384,6 +389,7 @@ public:
void didChangeContentsSize();
void pageScaleFactorChanged();
+ void mainFrameScrollOffsetChanged();
// Returns true if popup menus should be rendered by the browser, false if
// they should be rendered by WebKit (which is the default).
@@ -687,8 +693,7 @@ private:
bool m_ignoreInputEvents;
float m_compositorDeviceScaleFactorOverride;
- WebSize m_rootLayerOffset;
- float m_rootLayerScale;
+ TransformationMatrix m_rootLayerTransform;
// Webkit expects keyPress events to be suppressed if the associated keyDown
// event was handled. Safari implements this behavior by peeking out the

Powered by Google App Engine
This is Rietveld 408576698