Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2237433003: [turbofan] Utilize type information for alias analysis. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Utilize type information for alias analysis. If the intersection of the types of nodes a and b is empty, then there's no way that a and b could ever refer to the same object, so we can use that information for alias analysis. Drive-by-fix: Improve use of types to enable typed alias analysis to become more effective. Also fix an ASAN issue uncovered by this CL. R=jarin@chromium.org Committed: https://crrev.com/c0439051d63538099086c3e75012093f7052a487 Cr-Commit-Position: refs/heads/master@{#38567}

Patch Set 1 #

Patch Set 2 : Fix ASAN redness. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M src/compiler/access-builder.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M src/compiler/access-info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/load-elimination.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 5 chunks +12 lines, -19 lines 0 comments Download
M src/field-type.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-11 03:52:27 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a low hanging fruit for the alias analysis. Please take a look. ...
4 years, 4 months ago (2016-08-11 03:54:25 UTC) #4
Jarin
lgtm
4 years, 4 months ago (2016-08-11 05:27:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237433003/20001
4 years, 4 months ago (2016-08-11 05:28:39 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 05:41:38 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 05:41:49 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0439051d63538099086c3e75012093f7052a487
Cr-Commit-Position: refs/heads/master@{#38567}

Powered by Google App Engine
This is Rietveld 408576698