Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: src/compiler/load-elimination.cc

Issue 2237433003: [turbofan] Utilize type information for alias analysis. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix ASAN redness. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/access-info.cc ('k') | src/compiler/typer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/load-elimination.cc
diff --git a/src/compiler/load-elimination.cc b/src/compiler/load-elimination.cc
index ab7b893e81362da3d30289940e6e64763e435c02..c579673ba8c1ca9176d86aaeef5c3340e3b83ea8 100644
--- a/src/compiler/load-elimination.cc
+++ b/src/compiler/load-elimination.cc
@@ -18,6 +18,9 @@ enum Aliasing { kNoAlias, kMayAlias, kMustAlias };
Aliasing QueryAlias(Node* a, Node* b) {
if (a == b) return kMustAlias;
+ if (!NodeProperties::GetType(a)->Maybe(NodeProperties::GetType(b))) {
+ return kNoAlias;
+ }
if (b->opcode() == IrOpcode::kAllocate) {
switch (a->opcode()) {
case IrOpcode::kAllocate:
@@ -111,6 +114,7 @@ LoadElimination::AbstractElements::Kill(Node* object, Node* index,
that->elements_[that->next_index_++] = element;
}
}
+ that->next_index_ %= arraysize(elements_);
return that;
}
}
@@ -164,6 +168,7 @@ LoadElimination::AbstractElements::Merge(AbstractElements const* that,
}
}
}
+ copy->next_index_ %= arraysize(elements_);
return copy;
}
« no previous file with comments | « src/compiler/access-info.cc ('k') | src/compiler/typer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698