Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: build/config/ios/rules.gni

Issue 2237233002: Clean up GN template code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 5a9b20999961ed7d292bef6c81c09b03b28348cb..59004d08a14b6a895bf160fc4153ab000cfab6a2 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -499,45 +499,6 @@ template("ios_app_bundle") {
}
}
}
-
- # TODO(crbug.com/395883): ensure those variables are marked as used to
sdefresne 2016/08/11 23:23:03 Those are removed as part of https://codereview.ch
- # avoid errors while running "gn gen".
- if (defined(invoker.entitlements_path)) {
- assert(invoker.entitlements_path != "",
- "mark invoker.entitlements_path as used")
- }
- if (defined(invoker.bundle_extension)) {
- assert(invoker.bundle_extension != "",
- "mark invoker.bundle_extension as used")
- }
- if (defined(invoker.bundle_extension)) {
- assert(invoker.bundle_extension != "",
- "mark invoker.bundle_extension as used")
- }
- if (defined(invoker.entitlements_path)) {
- assert(invoker.entitlements_path != "",
- "mark invoker.entitlements_path as used")
- }
- if (defined(invoker.extra_substitutions)) {
- assert(invoker.extra_substitutions != [],
- "mark invoker.extra_substitutions as used")
- }
- if (defined(invoker.info_plist)) {
- assert(invoker.info_plist != "", "mark invoker.info_plist as used")
- }
- if (defined(invoker.info_plist_target)) {
- assert(invoker.info_plist_target != "",
- "mark invoker.info_plist_target as used")
- }
- if (defined(invoker.product_type)) {
- assert(invoker.product_type != "", "mark product_type as used")
- }
- if (defined(invoker.bundle_deps)) {
- assert(invoker.bundle_deps != [], "mark bundle_deps as used")
- }
- if (defined(invoker.bundle_deps_filter)) {
- assert(invoker.bundle_deps_filter != [], "mark bundle_deps_filter as used")
- }
}
set_defaults("ios_app_bundle") {
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698