Clean up GN template code.

build/config/ios/rules.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ios/ios_sdk.gni")
 import("//build/config/mac/base_rules.gni")
 import("//build/config/mac/symbols.gni")
 
 _is_secondary_build =
     additional_toolchains != [] && current_toolchain != default_toolchain
@@ skipping 481 matching lines @@
         # so do not use rebase_path here.
         foreach(_framework, invoker.extra_system_frameworks) {
           code_signing_args += [ "-F=" + _framework ]
         }
       }
       if (!ios_enable_code_signing) {
         code_signing_args += [ "--disable-code-signature" ]
       }
     }
   }
-
-  # TODO(crbug.com/395883): ensure those variables are marked as used to

[sdefresne, 2016/08/11 23:23:03]

Those are removed as part of https://codereview.chromium.org/2219323002/. I
would recommend dropping the changes in that file to avoid conflicting.

-  # avoid errors while running "gn gen".
-  if (defined(invoker.entitlements_path)) {
-    assert(invoker.entitlements_path != "",
-           "mark invoker.entitlements_path as used")
-  }
-  if (defined(invoker.bundle_extension)) {
-    assert(invoker.bundle_extension != "",
-           "mark invoker.bundle_extension as used")
-  }
-  if (defined(invoker.bundle_extension)) {
-    assert(invoker.bundle_extension != "",
-           "mark invoker.bundle_extension as used")
-  }
-  if (defined(invoker.entitlements_path)) {
-    assert(invoker.entitlements_path != "",
-           "mark invoker.entitlements_path as used")
-  }
-  if (defined(invoker.extra_substitutions)) {
-    assert(invoker.extra_substitutions != [],
-           "mark invoker.extra_substitutions as used")
-  }
-  if (defined(invoker.info_plist)) {
-    assert(invoker.info_plist != "", "mark invoker.info_plist as used")
-  }
-  if (defined(invoker.info_plist_target)) {
-    assert(invoker.info_plist_target != "",
-           "mark invoker.info_plist_target as used")
-  }
-  if (defined(invoker.product_type)) {
-    assert(invoker.product_type != "", "mark product_type as used")
-  }
-  if (defined(invoker.bundle_deps)) {
-    assert(invoker.bundle_deps != [], "mark bundle_deps as used")
-  }
-  if (defined(invoker.bundle_deps_filter)) {
-    assert(invoker.bundle_deps_filter != [], "mark bundle_deps_filter as used")
-  }
 }
 
 set_defaults("ios_app_bundle") {
   configs = default_executable_configs
 }
 
 # Template to build an application extension bundle for iOS.
 #
 # This should be used instead of "executable" built-in target type on iOS.
 # As the template forward the generation of the application executable to
@@ skipping 929 matching lines @@
       "-rpath",
       "-Xlinker",
       "@loader_path/Frameworks",
     ]
   }
 }
 
 set_defaults("ios_xctest_test") {
   configs = default_executable_configs
 }