Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2237153002: Use consistent values for enabled_component_updates throughout an update. (Closed)

Created:
4 years, 4 months ago by Sorin Jianu
Modified:
4 years, 4 months ago
Reviewers:
waffles
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use consistent values for enabled_component_updates throughout an update. The upcoming group policy control for the component updates will support dynamic refresh. That means that the enable/disable state for the updates, as reported by the Confogurator can change during an update task. This can lead to inconsistent behavior while running an update task. To support this dynamic scenario, the update context retains the enable/disable state of the updates as an immutable value created at construction time. This value is used throughout an update task and its dependent update actions. TBR=waffles@chromium.org BUG=624128 Committed: https://crrev.com/590921d35fcece61e518705b432bd61f01a17c4b Cr-Commit-Position: refs/heads/master@{#411450}

Patch Set 1 #

Patch Set 2 : Fix UT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -31 lines) Patch
M components/update_client/action.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/action_update_check.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/update_client/test_configurator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_checker.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/update_client/update_checker.cc View 5 chunks +6 lines, -3 lines 0 comments Download
M components/update_client/update_checker_unittest.cc View 12 chunks +31 lines, -26 lines 0 comments Download
M components/update_client/update_client_unittest.cc View 1 15 chunks +22 lines, -0 lines 0 comments Download
M components/update_client/update_engine.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/update_client/update_engine.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237153002/20001
4 years, 4 months ago (2016-08-11 21:46:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 23:48:54 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 23:52:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/590921d35fcece61e518705b432bd61f01a17c4b
Cr-Commit-Position: refs/heads/master@{#411450}

Powered by Google App Engine
This is Rietveld 408576698