Use consistent values for enabled_component_updates throughout an update.

components/update_client/update_client_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_path.h"
@@ skipping 217 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
+      EXPECT_TRUE(enabled_component_updates);
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE,
           base::Bind(update_check_callback, 0, UpdateResponse::Results(), 0));
       return true;
     }
   };
 
   class FakeCrxDownloader : public CrxDownloader {
    public:
     static std::unique_ptr<CrxDownloader> Create(
@@ skipping 86 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
       <?xml version='1.0' encoding='UTF-8'?>
       <response protocol='3.0'>
         <app appid='jebgalgnebhfojomionfpkfelancnnkf'>
           <updatecheck status='ok'>
             <urls>
               <url codebase='http://localhost/download/'/>
@@ skipping 166 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
       <?xml version='1.0' encoding='UTF-8'?>
       <response protocol='3.0'>
         <app appid='jebgalgnebhfojomionfpkfelancnnkf'>
           <updatecheck status='ok'>
             <urls>
               <url codebase='http://localhost/download/'/>
@@ skipping 228 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
       <?xml version='1.0' encoding='UTF-8'?>
       <response protocol='3.0'>
         <app appid='jebgalgnebhfojomionfpkfelancnnkf'>
           <updatecheck status='ok'>
             <urls>
               <url codebase='http://localhost/download/'/>
@@ skipping 231 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       static int num_call = 0;
       ++num_call;
 
       UpdateResponse::Results results;
 
       if (num_call == 1) {
         /*
         Fake the following response:
         <?xml version='1.0' encoding='UTF-8'?>
@@ skipping 272 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
       <?xml version='1.0' encoding='UTF-8'?>
       <response protocol='3.0'>
         <app appid='jebgalgnebhfojomionfpkfelancnnkf'>
           <updatecheck status='ok'>
             <urls>
               <url codebase='http://localhost/download/'/>
@@ skipping 164 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       static int num_call = 0;
       ++num_call;
 
       UpdateResponse::Results results;
 
       if (num_call == 1) {
         /*
         Fake the following response:
         <?xml version='1.0' encoding='UTF-8'?>
@@ skipping 270 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE,
           base::Bind(update_check_callback, 0, UpdateResponse::Results(), 0));
       return true;
     }
   };
 
   class FakeCrxDownloader : public CrxDownloader {
    public:
@@ skipping 80 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
       <?xml version='1.0' encoding='UTF-8'?>
       <response protocol='3.0'>
         <app appid='jebgalgnebhfojomionfpkfelancnnkf'>
           <updatecheck status='ok'>
             <urls>
               <url codebase='http://localhost/download/'/>
@@ skipping 167 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE,
           base::Bind(update_check_callback, 0, UpdateResponse::Results(), 0));
       return true;
     }
   };
 
   class FakeCrxDownloader : public CrxDownloader {
    public:
@@ skipping 74 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       return false;
     }
   };
 
   class FakeCrxDownloader : public CrxDownloader {
    public:
     static std::unique_ptr<CrxDownloader> Create(
         bool is_background_download,
         net::URLRequestContextGetter* context_getter,
@@ skipping 26 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return nullptr;
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       return false;
     }
   };
 
   class FakeCrxDownloader : public CrxDownloader {
    public:
     static std::unique_ptr<CrxDownloader> Create(
         bool is_background_download,
         net::URLRequestContextGetter* context_getter,
@@ skipping 78 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       static int num_call = 0;
       ++num_call;
 
       EXPECT_LE(num_call, 3);
 
       int retry_after_sec(0);
       if (num_call == 1) {
         // Throttle the next call.
         retry_after_sec = 60 * 60;  // 1 hour.
@@ skipping 144 matching lines @@
    public:
     static std::unique_ptr<UpdateChecker> Create(
         const scoped_refptr<Configurator>& config,
         PersistedData* metadata) {
       return std::unique_ptr<UpdateChecker>(new FakeUpdateChecker());
     }
 
     bool CheckForUpdates(
         const std::vector<CrxUpdateItem*>& items_to_check,
         const std::string& additional_attributes,
+        bool enabled_component_updates,
         const UpdateCheckCallback& update_check_callback) override {
       /*
       Fake the following response:
 
       <?xml version='1.0' encoding='UTF-8'?>
       <response protocol='3.0'>
         <app appid='jebgalgnebhfojomionfpkfelancnnkf'>
           <updatecheck status='ok'>
             <urls>
               <url codebase='http://localhost/download/'/>
@@ skipping 16 matching lines @@
               <packages>
                 <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx'
                          hash_sha256='813c59747e139a608b3b5fc49633affc6db574373f
                                       309f156ea6d27229c0b3f9'/>
               </packages>
             </manifest>
           </updatecheck>
         </app>
       </response>
       */
+
+      // UpdateClient reads the state of |enabled_component_updates| from the
+      // configurator instance, persists its value in the corresponding
+      // update context, and propagates it down to each of the update actions,
+      // and further down to the UpdateChecker instance.
+      EXPECT_FALSE(enabled_component_updates);
+
       UpdateResponse::Result::Manifest::Package package1;
       package1.name = "jebgalgnebhfojomionfpkfelancnnkf.crx";
       package1.hash_sha256 =
           "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87";
 
       UpdateResponse::Result result1;
       result1.extension_id = "jebgalgnebhfojomionfpkfelancnnkf";
       result1.crx_urls.push_back(GURL("http://localhost/download/"));
       result1.manifest.version = "1.0";
       result1.manifest.browser_min_version = "11.0.1.0";
@@ skipping 140 matching lines @@
   update_client->Update(
       ids, base::Bind(&DataCallbackFake::Callback),
       base::Bind(&CompletionCallbackFake::Callback, quit_closure()));
 
   RunThreads();
 
   update_client->RemoveObserver(&observer);
 }
 
 }  // namespace update_client