Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2236973004: Pass the bundle product_type to the actool invocation. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
CC:
chromium-reviews, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@product_type
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass the bundle product_type to the actool invocation. With Xcode 8, the invocation of actool need to contain the type of the bundle containing the asset catalog, pass the information from the create_bundle target to the actool command. BUG=634373 Committed: https://crrev.com/bf8b26608b67a274cf7b5ca99446043e9e197394 Cr-Commit-Position: refs/heads/master@{#411865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M build/toolchain/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/mac/compile_xcassets.py View 4 chunks +18 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
sdefresne
Please take a look. This depends on https://codereview.chromium.org/2239943002/ landing and rolling.
4 years, 4 months ago (2016-08-11 23:12:52 UTC) #2
sdefresne
+justincohen: FYI
4 years, 4 months ago (2016-08-11 23:17:47 UTC) #3
brettw
lgtm
4 years, 4 months ago (2016-08-11 23:28:17 UTC) #4
justincohen
lgtm
4 years, 4 months ago (2016-08-12 01:11:24 UTC) #6
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-12 22:33:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236973004/1
4 years, 4 months ago (2016-08-13 01:51:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 02:44:48 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 02:50:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf8b26608b67a274cf7b5ca99446043e9e197394
Cr-Commit-Position: refs/heads/master@{#411865}

Powered by Google App Engine
This is Rietveld 408576698