Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2236933003: [LayoutNG] Add writing mode to NGDerivedConstraintSpace (Closed)

Created:
4 years, 4 months ago by eae
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add writing mode to NGDerivedConstraintSpace Split NGDerivedConstraintSpace into a separate header and add direction and writing mode fields. Also change it to use NGLogicalOffset and Size instead of individual LayoutUnit fields for the offset and size values. BUG=635619 R=cbiesinger@chromium.org Committed: https://crrev.com/b76f8a89f3050ce49def73bc11fd08d055faf44c Cr-Commit-Position: refs/heads/master@{#411389}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -32 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 2 chunks +10 lines, -19 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
eae
4 years, 4 months ago (2016-08-11 15:41:23 UTC) #1
cbiesinger
lgtm
4 years, 4 months ago (2016-08-11 15:57:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236933003/20001
4 years, 4 months ago (2016-08-11 16:01:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/276142)
4 years, 4 months ago (2016-08-11 17:19:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236933003/20001
4 years, 4 months ago (2016-08-11 17:24:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 18:58:14 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 18:59:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b76f8a89f3050ce49def73bc11fd08d055faf44c
Cr-Commit-Position: refs/heads/master@{#411389}

Powered by Google App Engine
This is Rietveld 408576698